search

ibspoof / ng-iScroll

AngularJS (1.2+) directive that enables iScroll 5.x to work
143 stars 72 forks source link

capitalize "i" in IScroll #20

Open benjamingeorge opened 10 years ago

benjamingeorge commented 10 years ago

On line 82 you have 'new iScroll' which resulted in an undefined error. To get this to work in my angular project I needed a capital " I " such as "new IScroll() "

diegolameira commented 10 years ago

@benjamingeorge you're using the wrong file, the capitilized "i" is for iscroll5, if you are using iscroll5 then you must use 1.2b ng-iscroll.js...as readme says:

"AngularJS Module that enables iScroll 4.x to work using a directive. If you are looking for a iScroll 5 compatible version please checkout the ng-iScoll 1.2b branch"

benjamingeorge commented 10 years ago

Yeah I saw that. I installed via Bower and since the 1.2 branch of iscroll is the only one with a bower.json I assumed installing it with bower would pull the that branch. Is this not the case? Do I have to download the zip?

On Dec 4, 2013, at 8:25 PM, Diego Lameira notifications@github.com wrote:

@benjamingeorge you're using the wrong file, the capitilized "i" is for iscroll5, if you are using iscroll5 then you must use the 1.2b ng-iscroll.js...as readme says:

"AngularJS Module that enables iScroll 4.x to work using a directive. If you are looking for a iScroll 5 compatible version please checkout the ng-iScoll 1.2b branch"

— Reply to this email directly or view it on GitHub.

diegolameira commented 10 years ago

Look, you can get sources in bower from specific branches... If you run "bower help install" you'll get something like this:

Endpoints...

  • #

    Where:

  • is a package URL, physical location or registry name
  • is a valid range, commit, branch, etc.

With that in mind, you can run "bower install ng-iScroll#v1.2b --save-dev"

So, no need to download it manually.

benjamingeorge commented 10 years ago

thank you.

On Dec 4, 2013, at 9:14 PM, Diego Lameira notifications@github.com wrote:

Look, you can get sources in bower from specific branches... If you run "bower help install" you'll get something like this:

Endpoints...

#

Where:

is a package URL, physical location or registry name

is a valid range, commit, branch, etc. With that in mind, you can run "bower install ng-iScroll#v1.2b --save-dev" So, no need to download it manually. — Reply to this email directly or view it on GitHub.
neoswf commented 10 years ago

Thank you @diegolameira ! This small line (how to install a specific branch) saved me lots of time. Thank you!

racingcow commented 10 years ago

This helped me as well. It might be worthwhile to stick a comment in the readme about getting the v1.2b branch for Bower noobs like me.