ibuildingsnl / qa-tools

A set of quality assurance tools that are easily configurable through an installer
https://ibuildingsnl.github.io/qa-tools
MIT License
12 stars 7 forks source link

Dowloading Composer slows down pre-commit hook #16

Closed melvin-ibuildings closed 10 years ago

melvin-ibuildings commented 10 years ago

original created by lucasvanlierop

Please add some form of caching

melvin-ibuildings commented 10 years ago

original created by mvdbos

Simplest solution: put composer.phar in the root of your project (and in git). It checks for that

melvin-ibuildings commented 10 years ago

original created by lucasvanlierop

Ok did that for now

melvin-ibuildings commented 10 years ago

original created by seggen-ibuildings

How about checking if there is a composer binary in the environment PATH? ln -s $(which composer) composer.phar should then do the trick.

melvin-ibuildings commented 10 years ago

original created by mvdbos

I feel a PR coming...

melvin-ibuildings commented 10 years ago

original created by lucasvanlierop

Which would be so much easier if the project was open source and and we did not have to use a private fork of the QA-Tools ;-)

melvin-ibuildings commented 10 years ago

original created by mvdbos

patience my boy, patience... Will happen this quarter

Groeten,

ibuildings WEB & MOBILE APP DEVELOPMENT

Matthijs van den Bos CTO

mobile: +31 6 44 99 86 23 skype: matthijs-ibuildings e-mail: matthijs@ibuildings.nl phone: +31 88 00 24 000 www.ibuildings.nl

To all agreements with Ibuildings.nl BV, our general terms and conditionshttp://www.ibuildings.nl/algemene_voorwaarden apply.

On Thu, Jan 16, 2014 at 9:28 AM, Lucas van Lierop notifications@github.comwrote:

Which would be so much easier if the project was open source and and we did not have to use a private fork of the QA-Tools ;-)

— Reply to this email directly or view it on GitHubhttps://github.com/ibuildingsnl/qa-tools/issues/90#issuecomment-32450003 .

mvdbos commented 10 years ago

This is no longer an issue. QA-Tools are run on working dir, so existing composer installs are used if present