search

ibutsu / ibutsu-server

Ibutsu is a test result aggregator
https://ibutsu-project.org
MIT License
17 stars 22 forks source link

React 18 & Patternfly 5 Upgrades #494

Closed LightOfHeaven1994 closed 4 months ago

LightOfHeaven1994 commented 7 months ago

This PR contains:

  1. React router dom upgrade v5 -> v6
  2. React upgrade 17 -> 18
  3. Patternfly upgrade 4 -> 5
  4. Other packages upgrade
  5. Couple minor backend bugfixes (this was needed to test Frontend changes)
  6. Small Frontend bugfixes/improvements
  7. Test fixes
computercamplove commented 5 months ago

@LightOfHeaven1994 For some reason alerts doesn't go away when i import archive Screenshot from 2024-05-17 18-51-45, even if i navigate to different page, only when i reload page. could you reproduce it?

computercamplove commented 5 months ago
  1. Jenkins heatmap is not working for me, i copied same settings from production image

update: the issue is not in widget but in what metadata i use - it works for singe plugin, but not for common-pipelines/{prod-test-suite}

mshriver commented 5 months ago

@LightOfHeaven1994 thanks for picking this up - Can you address @computercamplove concern above, and look at updating the frontend container to node:18 in this?

https://github.com/ibutsu/ibutsu-server/pull/498

I'm hitting some of this in this MR, where I included a change to node:18 for the ibutsu-pod.sh script for local dev envs.

Node 16 is past end of life and we need to update it - I don't want 498 to completely turn into this PR, I started addressing some of the deprecations and then saw you're doing that here.

I'll keep node:16 in MR498's branch and then can rebase on top of this?

LightOfHeaven1994 commented 5 months ago

@LightOfHeaven1994 For some reason alerts doesn't go away when i import archive Screenshot from 2024-05-17 18-51-45, even if i navigate to different page, only when i reload page. could you reproduce it?

I can reproduce it. Will take a look :+1:

LightOfHeaven1994 commented 5 months ago
  1. Jenkins heatmap is not working for me, i copied same settings from production image

update: the issue is not in widget but in what metadata i use - it works for singe plugin, but not for common-pipelines/{prod-test-suite}

This happens because you probably used "Project 1" when you were uploading results, but then you switched to another project that has no these uploads (no data). This is not a bug but it's just how ibutsu RBAC works

LightOfHeaven1994 commented 5 months ago

@LightOfHeaven1994 For some reason alerts doesn't go away when i import archive Screenshot from 2024-05-17 18-51-45, even if i navigate to different page, only when i reload page. could you reproduce it?

fixed :)