search

iby / twig-js-markdown

Markdown extension for twig.js
8 stars 2 forks source link

Add ability to pass options to marked #2

Closed chrisvanpatten closed 5 years ago

chrisvanpatten commented 6 years ago

After a long delay, I had a chance to take a crack at this.

Unfortunately I can't actually get the code to build; I'm reasonably sure this is due to the dependencies having changed pretty dramatically since the last commit on this repo. I have just about no experience with Typescript, so I'm not really able to debug and figure out exactly what's going on.

That said I'm fairly confident my code is correct; it's a really simple change so hopefully it can be easily merged in :)

In the change, the twig markdown function will now accept a second parameter, an object of options that are passed directly to marked.

Example:

twigMarkdown(Twig, {
  smartypants: true,
})

Fixes #1. Thanks!

langy commented 5 years ago

Hey @ianbytchek, is there any chance you could get this change merged into master and released please? I also would love to be able to pass through marked options so I can turn off the automatically added IDs on headings; this is something that causes huge headaches when you want valid mark-up (duplicate IDs galore).

Many thanks @chrisvanpatten for adding ability in the first place :)

iby commented 5 years ago

😫 Sorry fellas, been very-very busy… Will review over the weekend.

iby commented 5 years ago

@chrisvanpatten Thanks for the PR, there was a conflict after getting everything up-to-date and I ended up copying your changes across. Would appreciate if you guys (ping @langy) can test this and confirm everything's working.