search

ibz / lightning-shell

The shell for your personal server
https://lightningshell.app
MIT License
24 stars 13 forks source link

Refactor builds #1

Closed AaronDewes closed 2 years ago

AaronDewes commented 2 years ago

Please note that all of this is not tested yet, I'll update this description & comment once it is.

Hi! I'm the maintainer of @runcitadel, a FOSS alternative to Umbrel.

I've found out about your image and think a few optimizations could be made to improve the image.

To do this, the build.sh script had to be changed too. Image name and version are an argument now, so you run it like

./build.sh ibz0/lightning-shell v1.1.1

In addition, instead of the architecture being part of the image name like before, it is now part of the version, so images get pushed like ibz0/lightning-shell:arm64-v1.1.1.

Running the build script shouldn't be necessary anymore because every build is now automated on GitHub. (To create a new version for example, just do git tag v1.1.2 && git push --tags after committing & pushing all commits for the new version).

ibz commented 2 years ago

@AaronDewes

I didn't know about @runcitadel, I'll have a look at it.

Using GitHub actions and the GitHub registry are indeed a good idea.

Indeed, Bullseye should work on Umbrel, however their docs suggested using Buster (because it's already cached) and I prefer to keep it that way on Umbrel at least. Maybe we could make multiple builds - one using Buster and one using Bullseye?

Yup, we could install some additional editors. And any additional utilities that you think would be useful - I was looking at things like gping, bandwhich, bottom... just didn't get around to do it.

Anyway, let me know once it is tested, and I'll test it as well. But again, I prefer to keep the Buster build around for now just to keep the Umbrel guys happy.

Thanks a lot!

AaronDewes commented 2 years ago

I've asked Lounès from Umbrel over Telegram if Bullseye would be okay, but he hasn't answered yet. With bullseye, we could get build time to ~7 minutes because ttyd is included in Bullseye.

AaronDewes commented 2 years ago

That time was wrong, apt is way slower in qemu than I thought (still faster than make)

AaronDewes commented 2 years ago

The bullseye build is tested, works and is now live in the Citadel app store.

The user name is now also dynamic (ENV var USERNAME, default to Umbrel), I'll add that to the PR description in a minute.

ibz commented 2 years ago

Amazing, thanks!

Let's wait for a confirmation from Lounès then. Let me know if you have any news on that.

AaronDewes commented 2 years ago

I now added BOS (untested) and Debian Buster builds (also untested). The base image for these is now, after adding BOS, node:16-buster-slim. That image's base image is debian:buster-slim, so what Umbrel recommends.

ibz commented 2 years ago

Beautiful! Thank you so much, @AaronDewes !

almostheaven1863 commented 2 years ago

i am trying to use Lightning Shell to set up Charge LND for my node. I am unable to access nano. This is all new to me, so sorry for a beginner question.

ibz commented 2 years ago

@almostheaven1863 How are you trying to access nano? Typing "nano" should work.

almostheaven1863 commented 2 years ago

when i open app i see the lnshell@... ~$ If I type nano, it says bash: nano: command not found

AaronDewes commented 2 years ago

Try running this: sudo apt update && sudo apt install -y nano

almostheaven1863 commented 2 years ago

now it says bash: sudo: command not found

ibz commented 2 years ago

@almostheaven1863 Citadel or Umbrel? Can you type "about" and tell me the Lightning Shell version?

almostheaven1863 commented 2 years ago

umbrel Lightning Shell v0.1.1 by @ibz / https://ibz.me Read more at https://ibz.github.io/lightning-shell/ Pull Requests to add / update utilities are very welcome!

ibz commented 2 years ago

@almostheaven1863 Right... nano came later. I submitted 0.1.4 to Umbrel and it got merged. Should be there in the next release!

almostheaven1863 commented 2 years ago

i see. then that makes sense. i'm just trying to get my channels somewhat automated bc doing it manually takes forever. thanks for your help.

AaronDewes commented 2 years ago

You can DM me on telegram/Twitter and I can help you switch to Citadel. It's open source, has dark mode, and more up-to-date apps.

ibz commented 2 years ago

You can DM me on telegram/Twitter and I can help you switch to Citadel. It's open source, has dark mode, and more up-to-date apps.

Nice one! All very true. Meanwhile, my PR to add dark mode to Umbrel is sitting there and nobody cares. Oh well... https://github.com/getumbrel/umbrel-dashboard/pull/396