ibz / lightning-shell

The shell for your personal server
https://lightningshell.app
MIT License
24 stars 13 forks source link

Text is blank on iOS Safari/chrome #2

Open refazi opened 2 years ago

refazi commented 2 years ago

When using mobile browser like safari or chrome in iOS, the text is blank - looks like the characters are colored the same as the background.

AaronDewes commented 2 years ago

What version are you using? Buster (Umbrel) or Bullseye (Citadel)?

refazi commented 2 years ago

Citadel

ibz commented 2 years ago

Could be related to this: https://github.com/tsl0922/ttyd/issues/798

What iOS version are you using?

refazi commented 2 years ago

Yeah the issue looks similar, I’m on 15.2

ibz commented 2 years ago

It's been over a year since ttyd released a new version. Others are also asking for a new release https://github.com/tsl0922/ttyd/issues/784

I could try building it from master, though I don't really like that approach.

What do you think, @AaronDewes ?

AaronDewes commented 2 years ago

That would mean reverting some changes for bullseye in generate-dockerfile.sh, but it sounds like a good idea.

ibz commented 2 years ago

Hey @AaronDewes, I've made a new build with the last ttyd (on master). Could you try it on Citadel and confirm that the issue is fixed? If so, I will create a new tag and close the issue.

AaronDewes commented 2 years ago

I've published the new version to Citadel, but can't test it myself, @refazi it'd be great if you could try with the update apps button and waiting a few minutes.

refazi commented 2 years ago

I updated twice, the version in the App Store shows as 1.1.1, still have the same issue.

AaronDewes commented 2 years ago

Can you try to SSH in and run ~/citadel/events/triggers/app-update

ibz commented 2 years ago

@AaronDewes is the SHA256 in app.yaml the correct one though? I am trying to run that container on my Umbrel and can't.

This one, I mean https://github.com/runcitadel/apps/commit/edf35a0efd18807693d4e10ca25deafc2149e5b9

AaronDewes commented 2 years ago

Thanks, that was the problem. Looks like I had another sha256 copied and pasted that by accident

refazi commented 2 years ago

The app doesn’t seem to start, the docker log on syslog says “manifest unknown”

ibz commented 2 years ago

I think this is getting a bit confusing now, with so many versions flying around. I've created version 0.1.3 of lightning-shell and submitted a pull request to @runcitadel. Ideally we will be using tagged versions, not builds from master.

refazi commented 2 years ago

I still see an issue, the COI toner in version 0.1.3 doesn’t come up, I see the following error on the container log: Standard_init_linux.go:228: exec user process caused exec format error

ibz commented 2 years ago

Hmm, that is strange, that error should show up when you try to run a container built for the wrong architecture - like running the amd64 container on the Pi.

But the SHA in https://github.com/runcitadel/apps/blob/main/apps/lightning-shell/app.yml matches the SHA of the ARM64 build on https://github.com/ibz/lightning-shell/pkgs/container/lightning-shell/13252298?tag=v0.1.3-bullseye-slim .

Is there any other place where you are storing the image reference/SHA, @AaronDewes ? Or can it be that he did not update to the last yml?

Or ... are you running Citadel on something else than Raspberry Pi @refazi ?

Other than that, I don't understand how this would happen.

refazi commented 2 years ago

Yeah it’s running on x86, can you build it for that arch as well?

ibz commented 2 years ago

Yeah, v0.1.3 was built for x86 as well, but I wrongly added the SHA256 of the ARCH build (thinking Citadel is only used on Raspberry Pi, silly me).

I think @AaronDewes fixed it by now.

AaronDewes commented 2 years ago

I fixed it, but even after my PR to add a missing dependency, it's still broken. I'll debug it further

refazi commented 2 years ago

Btw I just installed the umbrel version via the umbrel 0.4.11 release and I have the same issue

ibz commented 2 years ago

Yes, Umbrel has the old version. I submitted to them before the fix. :)

ibz commented 2 years ago

@AaronDewes I just had a look at your app.yaml, it seems like you are using a build from master, that may be broken (master is sometimes broken).

You should be using v0.1.3, which works fine on my Umbrel.

ibz commented 2 years ago

Ha! I found something...

I think it's only the Bullseye image that is broken (libwebsockets fails to load evlib_uv for some reason) whereas the Buster image works fine. Hence it worked for me on Umbrel (using Buster).

I'll investigate further and come up with a fix, but before that, to summarize...

As a temporary fix:

AaronDewes commented 2 years ago

Sure, I'll try to go back to buster.

ibz commented 2 years ago

@AaronDewes I think the issue was this after all https://github.com/ibz/lightning-shell/commit/4c53e0986d7d2356f6edd717904bf0754b38ebf6#diff-5be359434de5b83c3988bbf1494c1dab5bb8110cf7141650fec0e06e02d4b1dcR102

Should be fixed now in master. I'll make a tag soon also.

ibz commented 2 years ago

BTW, v0.1.4 is released. I just submitted it to Umbrel. Could we add that to Citadel as well?

refazi commented 2 years ago

Updated to citadel 0.5.20 and 0.1.4 seems to be there. The app loads and the browser experience is great, but I still have the same issue with the mobile browsers via iOS

ibz commented 2 years ago

@refazi Thanks for double checking! Too bad... OK, we'll leave this issue open then for now.

editwentyone commented 2 years ago

this is still an open bug on safari iOS or macOS with lightning shell 1.1.0 on citadel 0.0.2

the guys over at unraid.com had also such an visual bug with the terminal shell, but I couldn't find how they fixed it. all I can tell is, its working there.

Bildschirmfoto 2022-05-09 um 13 34 41