search

ic-labs / django-icekit

GLAMkit is a next-generation Python CMS by the Interaction Consortium, designed especially for the cultural sector.
http://glamkit.com
MIT License
47 stars 11 forks source link

Only auto redirect to ?edit page when logged in and redirect target actually exists #186

Open mrmachine opened 7 years ago

mrmachine commented 7 years ago

Make a HEAD request against the ?edit URL and only redirect if it returns 200 OK. We do this in ACMI's Redirect404Middleware which sends 404s to the 2015 site only if the requested page exists there.

This would also avoid misleading users with an impression that they are viewing a preview version of a 404 page. See ixc/acmi#260