A `FileItem` content item referring to a `File` with non-ASCII content in the title causes 500 on page save

ic-labs / django-icekit

GLAMkit is a next-generation Python CMS by the Interaction Consortium, designed especially for the cultural sector.

http://glamkit.com

MIT License

47 stars 11 forks source link

A `FileItem` content item referring to a `File` with non-ASCII content in the title causes 500 on page save #298

Closed jmurty closed 6 years ago

jmurty commented 6 years ago

If an icekit.plugins.file.models.File item has non-ASCII characters in its title – or in any content used to generate a string representation of the File – when such a file is referred to by a page via a FileItem reference the page fails to save with a 500 error because the non-ASCII text cannot be encoded for display in the successful-save message.

See ixc/agsa#100

jmurty commented 6 years ago

NOTE This is a problem in more places in GLAMkit, I've found another occurrence in just a quick look. We should take this change to fix the issue in general, rather than just this specific case.

jmurty commented 6 years ago

This problem is now fixed in all places I could find it