search

ic005k / OCAuxiliaryTools

Cross-platform GUI management tools for OpenCore（OCAT）
MIT License
3.57k stars 329 forks source link

Ryzen and TRX40 quirk presets #341

Closed fabiosun closed 1 year ago

fabiosun commented 1 year ago

I see some changement done in the stuff I maintained and they are wrong!

Please correct them or please delete this: AMD CPU BaseConfigs plug-in package, pre-selected for AMD CPU Quirks, AMD kernel patch package, Italian description documentation provided and maintained by fabiosun. thank you

ic005k commented 1 year ago

Sorry, can you generate a PR? I really don't want to be the middleman, changing things around. Thanks!

fabiosun commented 1 year ago

@ic005k it is not correct to change things maintained from others without asking So it is difficult for me to help Sorry

fabiosun commented 1 year ago

to explain better:

image

why was added SetVirtualMap quirk in this preset and also in Ryzen preset?

When was this change made, and what explanation is given for it?

I need to add other important parts for the AMD community (related to the new AM5 system), but if OCAT changes important elements incorrectly, it is not possible to recommend OCAT to AMD users And that's a pity

ic005k commented 1 year ago

All the changes can be traced here:

https://github.com/ic005k/OCAuxiliaryTools/commits/master

ic005k commented 1 year ago

I checked and no one really changed anything about AMD:

https://github.com/ic005k/OCAuxiliaryTools/blob/master/Database/preset/Booter-Quirks.txt

As you can see from the above file, the original file contains "SetupVirtualMap", that is, "SetupVirtualMap" exists from the beginning.

ic005k commented 1 year ago

So, no one is going to change this but you, please check, thank you.

ic005k commented 1 year ago

All PR, here it is:

https://github.com/ic005k/OCAuxiliaryTools/pulls?q=is%3Apr+is%3Aclosed

You can also check.

ic005k commented 1 year ago

The most recent changes are here:

https://github.com/ic005k/OCAuxiliaryTools/commit/3cb97ec913147cda56a1de937cb40badd0b68277#diff-9c118997d46169442e31ef50 1a4a664927e343ba56510639ffa154a443ba38ee

It doesn't involve anything AMD, it's an Intel-related update provided by @5T33Z0.

fabiosun commented 1 year ago

I checked and no one really changed anything about AMD:

https://github.com/ic005k/OCAuxiliaryTools/blob/master/Database/preset/Booter-Quirks.txt

As you can see from the above file, the original file contains "SetupVirtualMap", that is, "SetupVirtualMap" exists from the beginning.

this was old and my proposed quirk to correct this error you can find in my old and closed issue see the attached image in the left actual booter quirk in the right image one of the old OCAT release

image
ic005k commented 1 year ago

Sorry, I never check these things. Since I don't have the ability to control this content, I decided to remove all AMD content from OCAT. OCAT officially no longer offers any AMD presets, thank you.

ic005k commented 1 year ago

Of course, if you still like OCAT, please make this content available unofficially, it is the only way to guarantee the correctness of the data. I appreciate your continued contribution to OCAT.

fabiosun commented 1 year ago

Sorry, I never check these things. Since I don't have the ability to control this content, I decided to remove all AMD content from OCAT. OCAT officially no longer offers any AMD presets, thank you.

if so please remove all AMD plist and my name as AMD contributor No reason to have partial config or instructions Thank you

5T33Z0 commented 1 year ago

I wouldn't remove the AMD content because it took him a lot of time to create.

ic005k commented 1 year ago

please remove all AMD plist and my name as AMD contributor

Ok, thanks.

ic005k commented 1 year ago

@5T33Z0 It is the best way to ensure the correctness of AMD data that OCAT does not provide relevant content officially. Because OCAT has a large number of participants, participants will inevitably modify some content by mistake, which is quite normal. But in any case, we must be tolerant to look at these things.

fabiosun commented 1 year ago

can you help me remove the references in the various read me that I can't remove from the fork? As you might have guessed I'm not a GitHub expert..but AMD I am a little bit. And having struggled to get OCAT accepted by the AMD community it didn't seem right to remove those quiks even as an option

I used OCAT at an educational level for non-expert users and with those options users were learning how to build an EFI for their system from scratch, without using EFIs found on the net I hope you get the point Thanks

ic005k commented 1 year ago

@fabiosun I'm sorry. I may not be able to help you. OCAT program has a bug, you can ask me, I really know little else, you can ask @5T33Z0, he is very good at it.

fabiosun commented 1 year ago

https://github.com/ic005k/OCAuxiliaryTools/blob/master/Database/BaseConfigs/Instructions_AMD.md this could be removed

AMD users will be use old OCAT database version if they like!

5T33Z0 commented 1 year ago

I think first to have to sync your fork with the latest upstream from the main repo, so you are on the same version so to speak. I use Github desktop for this.

But honestly, ic005k could do this all by himself as well – I don't really get it.

fabiosun commented 1 year ago

I, on the other hand, don't understand why AMD presets (txt files) were removed, and as the reason was that the developer doesn't know AMD system

Until yesterday they were fine today not? Then, the developer tests all quirks in person on all Intel machines? I am really sorry, because, initial misunderstandings with you aside, I put a lot of effort into this app, which I still think is very good But I don't like that some things that I had prepared for it are "cut out" for no plausible reason I accept the decision but leave it to others to improve the app on the AMD side

5T33Z0 commented 1 year ago

I don't get it either. It's not like I have all the Intel CPUs and mainboards for all of theise configs either. If I would I would probably be running a computer store right now. ;)

So in this regard all the Intel configs are just as unproven as all the AMD configs…

fabiosun commented 1 year ago

@ic005k Remove AMD related content. OCAT no longer bundles any AMD-related content. this above could be a better description of new OCAT release because,please I am not a customer care center for all AMD users :) thank you

ic005k commented 1 year ago

@fabiosun This doesn't prevent you from providing AMD-related content, it's just that OCAT is no longer bundling it, and since I can't control whether AMD content will change in the future, it's best if OCAT doesn't provide it. I hope you understand. Thank you.

Well, I wasted an evening on this nonsense.

fabiosun commented 1 year ago

Well, I wasted an evening on this nonsense.

here it's afternoon, but in honesty I have to tell you that you started this "nonsense" by deleting things that had been in your app for more than a year.

However, it's your right and you were right to do it! have a nice evening!

5T33Z0 commented 1 year ago

@fabiosun I can host the AMD plists and Settings on my OC-Little Repo, if you like. Which Quirks need to be fixed for AMD you say?

ic005k commented 1 year ago

@fabiosun Thank you. The best way is that you maintain a separate AMD database on Github and there will never be any problems. Of course, if you want to, OCAT is happy to point to your AMD database in the menu or somewhere, and the user can download and use the database.

ic005k commented 1 year ago

@fabiosun Because we think you are too strict a person to allow anyone to touch anything of yours, which is really unavoidable for a multi-person project. However, no matter who modified your AMD related content at any time, I, as the main person responsible for the project, sincerely apologize to you. I'm really sorry. I hope OCAT is always open and anyone can participate and change or improve anything in it. thank you.

fabiosun commented 1 year ago

@fabiosun Because we think you are too strict a person to allow anyone to touch anything of yours, which is really unavoidable for a multi-person project. I work for life in many multi person project... And people can touch my work if it is correct to do it. AMD quirks have been good for more than a year then OCAT devs decided to delete it.

I accept your decision because I am a guest in your house ;) You can't convince me of what you are claiming, though. Anyone who wants to modify AMD things for your program does and will always do so by taking responsibility for the modification with a PR

I only responded to the fact that it was said here that I had made those modifications! Which is not true

I still wish you and your app the best of successes

@5T33Z0 thanks but I am not interested in maintaining a database in other places than the parent company producing the software :)

5T33Z0 commented 1 year ago

@fabiosun Okay. Whatever. Here are some refined instructions if you you choose to host the AMD files on your github.

Generating and configuring AMD EFIs using OpenCore Auxiliary Tools

Instructions

1. Generate a base EFI Folder

2. Modifying the config.plist

After the base EFI has been generated, config.plist must be modified according on the used CPU, GPU, additional hardware, peripherals, SMBIOS and BIOS.

NOTE: Open the config.plist with a plist editor to find additional information

2.1 Adjust the Core Count

The list below contains available configs for various AMD Chipsets. Based on the CPU used in your system you may have to adjust it (see "Description" for details).

AMD config Description
AMD-X370_generic.plist For 8-core AMD Ryzen. For CPUs with a different core count you have to modify the Kernel/Patch section, specifically the algrey - Force cpuid_cores_per_package patches, as explained here
AMD-X470_generic.plist For 8-core AMD Ryzen. For CPUs with a different core count you have to modify the Kernel/Patch section, specifically the algrey - Force cpuid_cores_per_package patches, as explained here
AMD-B450M_generic.plist For 8-core AMD Ryzen. For CPUs with a different core count you have to modify the Kernel/Patch section, specifically the algrey - Force cpuid_cores_per_package patches, as explained here
AMD-B550_generic.plist For 12-core AMD Ryzen. For CPUs with a different core count you have to modify the Kernel/Patch section, specifically the algrey - Force cpuid_cores_per_package patches, as explained here
AMD-X570_generic.plist For 16-core AMD Ryzen. For CPUs with a different core count you have to modify the Kernel/Patch section, specifically the algrey - Force cpuid_cores_per_package patches, as explained here
AMD-X399_generic.plist For 24-core AMD ThreadRipper. For CPUs with a different core count you have to modify the Kernel/Patch section, specifically the algrey - Force cpuid_cores_per_package patches, as explained here

2.2 Create an MMIO Whitelist

For AMD systems, creating an MMIO Whitelist is crucial for a working AMD ThreadRipper sTRX4 system. You can follow this guide to create your own MMIO Whitelist.

3 Deployment

n30f0x commented 1 year ago

It's a big pity that amd related content was deleted that abruptly, i was using it to handle own system and the content was pretty reliable to make templates by dortania's guide.

Could i propose to at least make amd database as experimental option? It's pretty big reason why i used OCAT in first place and outright deleting all of content makes OCAT less viable tool for me. In return you could ask people to validate configs or mark them as experimental. Thank you.