ic005k / OCAuxiliaryTools

Cross-platform GUI management tools for OpenCore(OCAT)
MIT License
3.49k stars 326 forks source link

[Feature Request] MacOS Update Ideas #82

Closed lucaszischka closed 2 years ago

lucaszischka commented 2 years ago

Hello ic005k,

first of all I want to tell you that I appreciate your work and love how fast you update the App to match the current acidanthera master branch/dev builds. Keep it up!

Nevertheless I would love to submit my feedback and my opinion on how to improve the app and to make the user flow even more intuitive. Please keep in mind, that most recommendations are based on my opinion and therefore don't hesitate to ask why I proposed each change.

Like I said, most of these are opinion based and if you want we can discuss each point individually. If you don't understand some of my ideas, don't hesitate to ask and I will provide further details.

Thank you and greetings from Munich, Lucas

ic005k commented 2 years ago

It's great to receive such detailed suggestions and feedback from you. I'd like to invite @llity and @5T33Z0 to join this discussion, I'd like to hear their opinions, they have their own unique insights in UI details control and user interaction, and I've adopted many of the opinions they provided before.

ic005k commented 2 years ago

I will collect opinions and make improvements to the app accordingly. You are welcome to speak up, thank you.

5T33Z0 commented 2 years ago
lucaszischka commented 2 years ago
ic005k commented 2 years ago
  • a preset menu would make more sense.

This is a good idea. Because my free time is very limited. Can you please tell me obviously how to preset? For example. ACPI section: first generation CPUs Which options to check, second generation CPUs which options to check, etc. That way I can just focus on the implementation programmatically without the distraction of having to gather and organize this content. Thanks.

ic005k commented 2 years ago

@5T33Z0

For example, you could organize it into a text file like the following. CPU name: xxx ACPI: xxx, xxx Booter: xxx Kernel: xxx, xxx xxx stands for the Quirks to be ticked

This allows me to read this text file directly through the program to implement the presets. Later maintenance can also be done through this text file, which is put together with the APP.

ic005k commented 2 years ago

@5T33Z0 Sure, at the end of the text, I will sign your name. "This content was compiled by 5T33Z0".

5T33Z0 commented 2 years ago

@ic005k Here's the list of Quirk presets. Somebody should counter-check it to verify.

Quirks_List._v2.0md.md.zip

ic005k commented 2 years ago

@5T33Z0 Quirks' pre-selection feature is very useful, nice job. More good ideas are welcome, thanks.

5T33Z0 commented 2 years ago

I Updated the document to v2. It contains quirks for High End Desktop PCs now.

I think quirks should be pre-selected and not just set cursive…

ic005k commented 2 years ago

I Updated the document to v2. It contains quirks for High End Desktop PCs now.

Okay, I'll get back to updating it. OCAT uses a completely open interface, the preselection files are placed in the "database" directory of OCAT, and the preselection can be updated by updating 4 txt files in the "preset" directory. The update can be done very easily.

5T33Z0 commented 2 years ago

Okay, cool. Thanks

ic005k commented 2 years ago

I think quirks should be pre-selected and not just set cursive…

This depends on the user's feedback. In most cases, we can help the user to choose, but we can't choose for them. That is, pre-selection cannot directly change the value of Quirks, otherwise, the user may resent it. I will keep optimizing it later when I have enough time. In the future, if you have free time, you can directly provide me with 4 txt files so I can put them on GitHub to complete the upgrade. Thanks.

lucaszischka commented 2 years ago

Maybe a button in the menu bar, called „Apply quirk recommendations“ would be the best way to keep the freedom of the user, but adding a auto-select feature.

5T33Z0 commented 2 years ago

Unnecessary intermediate step and unintuitive as well. Either the quirks are applied after choosing a preset or don't. But don't add more buttons where it's unnecessary. This is not the 80s where you kill any intuitive design with buttons on top of buttons. Everybody is free to unselect any quirks by themselves afterwards.

But bring back top Open and Recent Buttons to the toolbar.

lucaszischka commented 2 years ago

Im sorry I didn't checked the current implementation, before I wrote my comment. I wrote it based on the information provided to my by this thread. I have now downloaded the latest release and checked it out.

Nevertheless I would still suggest to add a button for selecting the quirks. This button could be placed on the right side of the picker and with the text "Apply". It would be disabled (gray) when no Preselection is applied, but after selecting something from the picker it changes to be enabled (blue/black). This would make it easier to apply the changes instantaneously, but would not hurt the user interface.

In opposite to 5T33Z0 I really like the changes in the toolbar and i think it is now much more intuitive. I love (all) of the changes you made based on my opinion.

Regarding 5T33Z0 comment: Please keep in mind that this is only my opinion and I don't want to offed anyone. Design is a really controversial topic and it is normal that opinions are different; but you are right, adding a Button to the top bar would make it unintuitive and im sorry for not checking the current implementation before commenting something.

I also updated my initial issue and removed the already changed or fixed suggestions. Last but not least I want to thank ic005k for his great work 5T33Z0 for providing the files for making the qurirk selection feature possible, keep it up!

5T33Z0 commented 2 years ago

I have to open dozens of configs per day and I don't understand why there are no "open" and no "recent" buttons anymore. Nobody uses the backup button, but this is still there… I don't understand the reasoning behind it. And why is the toolbar pinned to the right now and not the left? Totally unusual and counter-intuitive…

Anyway, here are the quirks for 11th Gen Intel i5/i7/i9

Prerequisites:

Kernel > Emulate

Cpuid1Data: EB060900000000000000000000000000 Cpuid1Mask: FFFFFFFF000000000000000000000000

Booter:

Intel 10th Gen Comet Lake and 11th Gen Rocket Lake (Dektop/Mobile/Nuc)

Kernel:

Intel 11th Gen Rocket Lake (Dektop/Mobile/Nuc)

UEFI:

Intel 10th Gen Comet Lake and 11th Gen Rocket Lake (Dektop)

Intel 10th Gen Comet Lake and 11th Gen Rocket Lake (Mobile/NUC)

Intel 10th Gen Comet Lake and 11th Gen Rocket Lake (HP Desktop)

Intel 10th Gen Comet Lake and 11th Gen Rocket Lake (HP Mobile/NUC)

lucaszischka commented 2 years ago

I don't understand why there are no "open" and no "recent" buttons anymore.

In my opinion the average user uses the „Open“ and „Open Recent“ Button nearly never, because he only configures OpenCore for his own PC/Laptop and therefore only has one plist (maybe 2-3 if he has a backup or test-plist‘s). Therefore these buttons are only used once when opening the Programm. And because the majority of people don’t switch between plist a lot it is only used once per session; so there is no need for it in the menu bar.

I also want to refer to other popular apps again, because nearly every native or python app for macOS uses the macOS menu bar. So as an macOS User it is really counterintuitive when the buttons are place somewhere else. I don’t see a reason to destroy the default macOS behavior, by having a button in the top bar (after all it is just one click difference).

I have to open dozens of configs per day

I only think that in edge cases those buttons are really useful, like when writing a guide (and therefore creating plist‘s for every operating system) or when creating OpenCore Configrations for other people (friends, family or even selling them to strangers).

Nobody uses the backup button, but this is still there…

i think this is a really useful button, nevertheless I would also suggest to remove it from the top bar.

And why is the toolbar pinned to the right now and not the left? Totally unusual and counter-intuitive…

I really liked this change, but this is my personal opinion.

Anyway, I would like to thank you for your input and I think that discussions like this are really helpful. It makes it possible to get different input, discuss it and later implement the best version.

5T33Z0 commented 2 years ago

The issue has been resolved by implementing customization of the toolbar in the latest build.

Thanks to @ic005k

5T33Z0 commented 2 years ago

I've noticed that numerical values for "ProvideMaxSlide" and "SetApfsTrimTimeOut" are not applied when selecting presets.

lucaszischka commented 2 years ago

The issue has been resolved by implementing customization of the toolbar in the latest build.

Thanks to @ic005k

Yes indeed a very lovely solution. Thank you!

ic005k commented 2 years ago

@5T33Z0

If you have free time, you can make a generic profile for each CPU type, e.g. cpu1.plist cpu2.plist cpu3.plist etc. After that, put them into OCAT's configuration file database, and the user just needs to double-click an entry inside the configuration file database to automatically generate a complete EFI folder on the desktop. This greatly improves the efficiency and speed of configuring OC EFI for everyone, and I'm sure the majority of users will be very grateful.

5T33Z0 commented 2 years ago

BaseConfigs.zip

Included Configs

INTEL

High End Desktop

Intel Core i5/i7/i9

AMD

References

ic005k commented 2 years ago

@5T33Z0

Nice work! Back to you can package those missing AMD kext for me and I'll lay them out on GitHub, thanks.

ic005k commented 2 years ago

This time, OCAT's previously elaborate profile database finally came into play, after it had been sitting idle for a long time.

5T33Z0 commented 2 years ago
5T33Z0 commented 2 years ago

@ic005k Creating EFIs for Intel CPUs crashes the app a lot of times.

Updated configs: BaseConfigs.zip

ic005k commented 2 years ago

@5T33Z0

One small suggestion. Back please change the "/" in some of the file names to "-" or other characters, otherwise it will not be recognized under Windows. For details, please see.

https://github.com/ic005k/QtOpenCoreConfig/actions/runs/1537738534

5T33Z0 commented 2 years ago

Ahh, ok. I removed the the /. Latest Version: https://github.com/5T33Z0/OC-Little-Translated/blob/main/F_Desktop_EFIs/_BaseConfigs.zip?raw=true

The app no longer crashes! Yay. Thanks for the fix.

One more URL for the Kext Update list:

https://github.com/1Revenger1/ECEnabler

lucaszischka commented 2 years ago

It would be very cool, if there could be a (re)create vault button or maybe even if the app would recreate the vault automatically after saving.

5T33Z0 commented 2 years ago

@ic005k Is it possible to add a "Comment" column to to Config File list so I can some descriptions?

Something like this maybe? ConfigLIstComments

Or a dedicated section with a summary or similar.

Thanks.

ic005k commented 2 years ago

vault

At the moment I have no experience of using this and have never tried "vault", can you tell me how to do this? Alternatively, you could just tell me the exact steps.

5T33Z0 commented 2 years ago

Thanks for adding the "comments" feature. Is there a file where the info is stored, so I can share it with you once I am done adding all the descriptions? Thanks.

ic005k commented 2 years ago

Is there a file where the info is stored

It is automatically stored in the plist file "#ConfigComment". If the plist file does not have this "#ConfigComment" field, OCAT will automatically create it when the database interface is closed. Alternatively you can use any third party plist editor to add this "#ConfigComment".

AMD_Bulldoze+Jaguar_MacPro14,2_Kepler+.plist.zip

lucaszischka commented 2 years ago

vault

At the moment I have no experience of using this and have never tried "vault", can you tell me how to do this? Alternatively, you could just tell me the exact steps.

Here is an explanation of vaulting: https://dortania.github.io/OpenCore-Post-Install/universal/security/vault.html

But i will provide a detailed description:

A button (maybe in the menu bar, or even automatically on save), which is disabled when Misc -> Security -> Vault is set to "Optional".

Otherwise it can be pressed and it will perform the following action; it runs the sign.command file, which is bundled with OpenCorePkg -> Utilities -> Create Vault.

As far as I know, you can’t tell this command which EFI to sign, but I’m not sure. It automatically closes the EFI, which is in the same directory tree.

lucaszischka commented 2 years ago

I’m sorry, I just saw on your already added the feature.

ic005k commented 2 years ago

I just saw on your already added the feature.

I don't know if this is the case, please confirm, does it work?

lucaszischka commented 2 years ago

I will check it later today, I’m currently not at home.

5T33Z0 commented 2 years ago

@ic005k: For the next release, lease delete the existing base configs and readme and replace them with the files in this zip: https://github.com/5T33Z0/OC-Little-Translated/blob/main/F_Desktop_EFIs/_BaseConfigs.zip?raw=true

The first 2 configs contain a message because additional steps are necessary after the EFI folders are generated:

Bildschirmfoto

Thanks

5T33Z0 commented 2 years ago

Updated Kernel-Quirks.txt

https://github.com/5T33Z0/OC-Little-Translated/blob/main/F_Desktop_EFIs/preset/Kernel-Quirks.txt

Added the quirks templates to my repo which makes it easier to update them in the future:

https://github.com/5T33Z0/OC-Little-Translated/blob/main/F_Desktop_EFIs/preset/

lucaszischka commented 2 years ago

Update the original post to only contain the left over suggestions.