Allow newer versions of ice_cube to be used

icalendar / icalendar-recurrence

Easy recurrence expansion for iCalendar

MIT License

41 stars 27 forks source link

Allow newer versions of ice_cube to be used #16

Closed warmwaffles closed 7 years ago

warmwaffles commented 7 years ago

We are trying to move to a newer version of ruby, and this dependency needs to update in order to stop the errors.

/home/travis/build/company/project/vendor/bundle/ruby/2.4.0/gems/ice_cube-0.13.3/lib/ice_cube/validations/month_of_year.rb:7: warning: constant ::Fixnum is deprecated

warmwaffles commented 7 years ago

This does break older versions of ruby

Gem::InstallError: ruby_dep requires Ruby version >= 2.2.5, ~> 2.2.

warmwaffles commented 7 years ago

Oh it's the dev dependencies that break. Dropped the gaurd dependency.

jnraine commented 7 years ago

@warmwaffles thanks for this!

I've been meaning to bump this version for awhile now. After merging your changes, I ended up tweaking it slightly to be ~> 0.13. This allows minor version upgrades but not major versions. I figure we should review ice_cube 1.0 when it comes out before allowing it to be used.