search

icalendar / icalendar-recurrence

Easy recurrence expansion for iCalendar
MIT License
42 stars 27 forks source link

List tzinfo as runtime dependency #30

Closed Pyronix closed 1 year ago

Pyronix commented 2 years ago

Currently, tzinfo is listed as a development dependency.

But from its usage in time_util.rb we can see, it should be a runtime dependency.

This will cause issues, when the gem is used in a plain ruby project, where tzinfo is not required by activesupport for example.

For anyone encountering this issue, you can temporarily fix this by just requiring it alongside this gem yourself:

gem 'icalendar-recurrence'
gem 'tzinfo'
espen commented 2 years ago

Sounds good. Want to make a PR for it?

Pyronix commented 2 years ago

Sounds good. Want to make a PR for it?

I will try to submit one on the weekend, when i have a bit of free time.