New date formatting options

icambron / twix.js

:hourglass::left_right_arrow: A date range plugin for moment.js

https://isaaccambron.com/twix.js/

MIT License

379 stars 54 forks source link

New date formatting options #112

Closed emmajam closed 5 years ago

emmajam commented 5 years ago

Due to changes in the Japanese date standards the following new options are required

New Format Example - 2019年4月24日

Add in the options to:

showYearFirst (show the year before the day or month is shown YYYY/MM/DD)
spaceBeforeMonth (hide the space before the month value)
spaceBeforeDay (hide the space before the day value)

icambron commented 5 years ago

The code here looks great! A couple things before I can merge it:

Can you remove the dist/ stuff from the PR?
Can you unignore the package-lock file?

emmajam commented 5 years ago

hey @icambron done ✅ sorry for slow response!

icambron commented 5 years ago

Thanks! Merged in ea95d283b80bb85ea58447e5dcd9a1f552be71e0, released in 1.3.1. I'm having trouble getting the website rebuilt, so the release isn't on there yet, but you can't get it under the releases tab here on Github, or pull it from npm.