search

icambron / twix.js

:hourglass::left_right_arrow: A date range plugin for moment.js
https://isaaccambron.com/twix.js/
MIT License
379 stars 54 forks source link

bower.json: depend on moment js instead of moment #38

Closed benesch closed 10 years ago

benesch commented 10 years ago

http://momentjs.com lists momentjs as the official package, and other packages (like moment-range) depend on momentjs, not moment. Make this consistent to prevent Bower from installing multiple versions of Moment.js when both packages are listed as dependencies.

icambron commented 10 years ago

Hmm, shouldn't it match the name property here? (I know almost nothing about Bower)

neverfox commented 10 years ago

It should, but that's really on the package maintainer. Bower doesn't care what's in the name field (just like npm doesn't care what you put in your package.json name field), but rather what you register it as. I too have run into this, because for some reason moment is registered (and updated) under two different Bower names. The problem is that there are packages that use moment and packages that use momentjs in their Bower dependencies as a result of this. There's no real way to win unless they get rid of one, forcing everyone into a standard.

neverfox commented 10 years ago

Also, it looks like moment-range is using moment now.

benesch commented 10 years ago

@neverfox thanks for the insight. I'll take this upstream.

Looks like most plugins have standardized on moment so it's a nonissue. Sorry for the noise!