icambron / twix.js

:hourglass::left_right_arrow: A date range plugin for moment.js
https://isaaccambron.com/twix.js/
MIT License
379 stars 54 forks source link

Official Meteor integration #55

Closed splendido closed 9 years ago

splendido commented 9 years ago

Hi Isaac,

As you might know, the Meteor community is widely using Moment.js as well as your Twix.js. I had a wrapper package but last week I missed your new release, so I'm submitting this PR to integrate Meteor packaging directly into your repository: at the end of this merge process, in case you'll find yourself comfortable with it, we'll get automated new meteor package releases at every new release of Twix.

All you have to do after accepting this PR would be:

  1. create an account at https://meteor.com/ (click SIGN IN, then Create account). After you've done that, please let me know the name of the account, and I'll add you as a maintainer of the icambron organization (which has been alredy reserved to make things simpler for you, but we might transform it back to a regular private user if you're not comfortable with this or in case you're willing to personally publish and maintain the package...).
  2. head to Meteor Autopublish sign in with your gitHub account, locate this repository and enable it for autopublish by toggling the checkbox you'll find on the right side of the repository item. You can get an idea about how Meteor Autopublish works by having a quick look at this page, but basically it creates a web hook to let us know when you push new tags. And when you'll release new versions, autopublish.meteor.com will automatically take delivery for publishing the new version also for Meteor!

Please note that you will not be able to toggle your repository until you'll have the package.js file on your master branch.

Please also note that I've already published the current version of the package on Atmosphere (Meteor's package directory) under the name icambron:twix. But if you think another name would be a better fit (e.g. twixjs:twix, I've also reserved twixjs for you...), just let me know!

Thanks & best regards, Luca & the Meteor integrations team

icambron commented 9 years ago

Hi Luca,

Thanks for the patches, all good stuff, especially taking the versions out of package.json.

Besides my one point in the code itself, can you also remove the built JS files from the PR? As a rule, I insist on building that myself. If you make those changes, I'll merge it and then follow your instructions.

splendido commented 9 years ago

Build file removed!

Tnx for the very quick response :)

splendido commented 9 years ago

...actually there's another possibility: publish your package together with moment as momentjs:twix

this would highlight that the two packages are highly correlated, but I appreciate this might be a very personal choice I wouldn't take for you...

icambron commented 9 years ago

@splendido I'm pretty indifferent on where it goes, actually. Wherever you want it

splendido commented 9 years ago

Ok, great! I'd say momentjs:moment and momentjs:twix will make for a great couple of packages.

Hey @dandv, could you please add me, publish, and meteorpublish (for autopublish.meteor.com to work...) to the meteorjs organization?

After this I'll change the package name and than we can prooced on with this PR! :)

dandv commented 9 years ago

Done!

image

splendido commented 9 years ago

Ok, thanks @dandv.

@icambron: At this point I think we're ready to merge! :)

I'll trigger the publish with the new name once it'll be registered on autopublish.meteor.com (and after this hide icambron:twix from Atmosphere)

splendido commented 9 years ago

hey @icambron, this is how I managed to make it working also as a Meteor package. But feel free to change it if you can make it better/clearer...

icambron commented 9 years ago

Great, thanks! I'll go through those instructions later today.

splendido commented 9 years ago

:)

splendido commented 9 years ago

Actually, to be able to subscribe to autopublish.meteor.com you should also merge develop into master. ...your repo won't be recognised as a meteor package until you'll have a package.js file in your master branch :(

icambron commented 9 years ago

@splendido - Sorry, just getting to this now. I've merged the changes to Master and I've created a meteor username. It's isaaccambron (I wanted icambron, but it said that username was taken. I tried logging in as that user and it gave me an error that icambron doesn't have a password. I'm thinking this is perhaps a side effect of creating the icambron organization?). Anyway, I think the next step is for you to link my account to momentjs:twix?

splendido commented 9 years ago

Hei Isaac, tnx for going through all this.

I've just added isaaccambron to the momentjs organization (you should see it under the organizations section of your account page on meteor.com).

You're right the icambron name was taken by me when I first proposed to publish as icambron:twix (actually it's an organization at the moment..): I'll ask to transform it to an user (or to delete the org) so you can take ownership on it!

Inthe meanwhile, you can go to autopublish.meteor.com, login with your GitHub account and enable Twix for autopublish. Now that there's a package.js on the master branch you should see it as a meteor package and be able to toggle the switch on the right side...

From the next release on it will be published automagically ;-) ...I'll trigger the first publication by hands later on today.

icambron commented 9 years ago

Done.

splendido commented 9 years ago

Brilliant! ...you're officially the first participant in autopublish.meteor.com! Thank you! But there are other processes on their way, so you won't be alone for sure ;-)

I'll try to trigger the first publish by this evening (lets say 10 hours from now...). ...and I've just asked to transform icambron to a regular user (or to delete the org so you can register with it). I'll let you know when it's done.

icambron commented 9 years ago

Awesome, I'm glad it worked. Thanks for all the help.

icambron commented 9 years ago

@splendido I pushed up a new version today (0.6.2) that fixes a bug. Am I right in thinking that should have just published automatically published to Atmosphere?

splendido commented 9 years ago

Hi there, I'm sorry yesterday I didn't mentioned you that there are being some problems with the README.md file. See this issue I've just fired on Meteor.

I was not well aware of some recent updates went out with Meteor@1.0.3.1 :( ...autopublish.meteor.com was missing some (new) error detection, this is why your new version was tagged as successful even if it was not published to atmosphere! Now this is fixed and if you look at it now you'll see that the last publish attempt for twix failed...

For the first publish I triggered by hands I managed to fix the README on the local clone before calling meteor publish. I had no idea you were about to release another new version... :( ...and after the publication I moved out of home for the rest of the day.

Btw, the triggers for the new version correctly reached out to autopublish.meteor.com :)

I'm going to file another PR touching the package.js and README.markdown files to fix things in a few minutes.

splendido commented 9 years ago

Here we go: see #58.

I'll publish the latest release on atmosphere by hands, so you won't need to create a new one.

Tnx!

splendido commented 9 years ago

Hello Isaac,

I've checked with MDG and icambron (which is an organization) cannot be transformed to a regular user nor deleted because there's already a package published with it (the first icambron:twix I published at first and then made hidden...).

Btw, I've just added isaaccambron among the member of icambron and I'll remove myself as soon as you confirm you can see it.

I'd like to take the occasion to thank you again for your availability and collaboration in supporting this official Meteor integration! Thanks!

Luca

icambron commented 9 years ago

You're very welcome. I won't worry about the icambron address

splendido commented 9 years ago

Ok, fine. But, just in case, consider it as your (its also mine at the moment, but as already said you can reclaim it whenever you wish).

Thanks again, keep up the good work!

coveralls commented 8 years ago

Coverage Status

Changes Unknown when pulling 40f86f3a2e957c9a7f4f909641bd62229e53e716 on MeteorPackaging:meteor-integration into \ on icambron:develop**.