search

icambron / twix.js

:hourglass::left_right_arrow: A date range plugin for moment.js
https://isaaccambron.com/twix.js/
MIT License
379 stars 54 forks source link

Add floating point parameter to length method. #96

Closed feload closed 7 years ago

feload commented 7 years ago

Since moment "diff" method is able to receive an optional parameter for including floating point, I thought it was a good idea to add it to twix "length" method.

icambron commented 7 years ago

This looks good to me. The test failure is a bit mysterious; I'll look into that. One change I need from you though is to remove the built/minified files from your commit. Thanks!

feload commented 7 years ago

Awesome, thanks! Files removed.

icambron commented 7 years ago

Looks like you deleted the built files from the repo, not from the PR. I want the files, I just don't want your changes to them.

I also got Travis to give me the error (it was being weird when I first looked at this); it's complaining about the semicolons. You can run make lint to test that locally.

feload commented 7 years ago

Ok, I think we're good to go now. I'm sorry this is my first time contributing :)

icambron commented 7 years ago

No problem! Thanks for the contribution. I'll cut a new release with this soon.

icambron commented 7 years ago

@feload This is now released as part of 1.1.4