add support for 'include' option

icann-dns / puppet-nsd

puppet module to manage nsd

Apache License 2.0

1 stars 2 forks source link

add support for 'include' option #10

Closed and0x000 closed 5 years ago

and0x000 commented 5 years ago

closses https://github.com/icann-dns/puppet-nsd/issues/9

and0x000 commented 5 years ago

Mostly LGTM, could you also add a spec test

tests were added with https://github.com/icann-dns/puppet-nsd/pull/10/commits/10f8bbade22fd93d9f16f9979d27061ca6e8d823

and0x000 commented 5 years ago

It would be nice, if you could release a new version of the module soon after accepting the changes from my pull requests. I would like to use this puppet module of yours, but I need the additional features.

and0x000 commented 5 years ago

travis pipeline seems to have failed due to what looks like a ci-runner error to me. close+reopen to restart pipeline

b4ldr commented 5 years ago

looks fine to me