icann-dns / puppet-nsd

puppet module to manage nsd
Apache License 2.0
1 stars 2 forks source link

Missing dependency on logrotate module #5

Open htj opened 5 years ago

htj commented 5 years ago

Affected Puppet, Ruby, OS and module versions/distributions

How to reproduce (e.g Puppet code you use)

class { '::nsd': logfile => '/var/log/nsd.log', ... }

AFAICT the logrotate module is only needed of logfile is specified.

What are you seeing

Error: Evaluation Error: Error while evaluating a Resource Statement, Unknown resource type: 'logrotate::rule' (file: /tmp/puppet/modules/nsd/manifests/init.pp, line: 129, column: 5) on node ...

What behaviour did you expect instead

Output log

Any additional information you'd like to impart

At least a note on the logfile option, that is triggers a dependency on logrotate.

b4ldr commented 5 years ago

Thanks you for the bug report i have added logrotate to the dependencies and created version 0.3.2