icarus-consulting / Yaapii.Http

C# Library for Http Request
MIT License
7 stars 0 forks source link

Verano http port #24

Closed DFU398 closed 4 years ago

DFU398 commented 4 years ago

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x")

What is the current behavior? (You can also link to an open issue here)

What is the new behavior?

usage is similar to verano-http

Does this PR introduce a breaking change? (check one with "x")

If this PR contains a breaking change, please describe the impact and migration path for existing applications

It's an entirely new project.

Other information

Meerownymous commented 4 years ago

Really great, overall complete work! We now have the full port with docs, if the tests pass we can start right away using it :)

Also your research about the SingleTon HTTPClient is a very useful hint. We should soon integrate this in our main project. Putting Singleton Wire into the DI.

Please see my comments and check whether we can remove the class extensions. If the PR is merged we can release 2.0 and move this to open source area.

We can then suggest a link on www.elegantobjects.org via PR.

Please have a look at the tests - they should pass on AppVeyor.

DFU398 commented 4 years ago

If the PR is merged we can release 2.0 and move this to open source area.

If we want to make this open source, we should remove the Yaapii.Web.Asp and Yaapii.Json dependencies, those repositories are private. Should be easy though, Yaapii.Web.Asp is only needed for RandomPort in unit tests. We can add a class like that to this project and we can probably use Newtonsoft.Json instead of Yaapii.Json for JsonBody.

Let me know if i should make those changes.

Meerownymous commented 4 years ago

Yes, please please make the changes - you can copy AwaitedPort and RandomPort. When 2.0 is released we remove them from Web.ASP.

Fallback to newtonsoft is also good.