search

icarus523 / qcasDFtest

Unit Testing of QCAS datafiles
MIT License
0 stars 0 forks source link

Vijay S. Suggestions #3

Open icarus523 opened 6 years ago

icarus523 commented 6 years ago

• Verifying the new additions take a lot of time, especially when large number of games are added, so maybe randomly pick one or two new games and one random day seed from each month may be adequate (in line with the checklist).

• Is it possible to include the seed day used during calculation in the output – currently only seed value is shown?

• What is that % value shown which hashing each individual file within the BNK– sometimes it is more than 100%?

icarus523 commented 6 years ago

Point 3: It's the value for each file referenced in the BNK file against the seed displayed.

Fixed so it now shows just to 100%.

icarus523 commented 6 years ago

Point 1. The reason this takes a long time, is that a PSL entry is generated manually for each new game added. Meaning 31 seeds are used for each game.

Rationale 1: Completely verifying a PSL entry for a new game is more complete than verifying a game for a single day of a month.

Rationale 2: Aruze (Midas Gold & Dragon Gilt) games takes about 150 seconds (2.5 mins only) for each new game.

icarus523 commented 6 years ago

Point 2. Done. Output is now: 

Hashing: X17P40-XXLP-ZQ-0103.bin        Seed: 64514373      100%
Hashing: X17P40-XXLP-ZQ-0103.bin        Seed: 37783868      100%
Hashing: X17P40-XXLP-ZQ-0103.bin        Seed: 6C544B48      100%
Hashing: X17P40-XXLP-ZQ-0103.bin        Seed: 79537243      100%
Hashing: X17P40-XXLP-ZQ-0103.bin        Seed: 35795A58      100%
Hashing: X17P40-XXLP-ZQ-0103.bin        Seed: 35574B37      100%
Hashing: X17P40-XXLP-ZQ-0103.bin        Seed: 6466396E      100%
Hashing: X17P40-XXLP-ZQ-0103.bin        Seed: 706B4244      100%
Hashing: X17P40-XXLP-ZQ-0103.bin        Seed: 4467634C      100%
Hashing: X17P40-XXLP-ZQ-0103.bin        Seed: 6E554862      100%