icaruseu / mom-ca

Monasterium.net (http://www.monasterium.net/mom) - repository and collaborative archive

https://github.com/icaruseu/mom-ca/wiki

GNU General Public License v3.0

17 stars 11 forks source link

Seals #1062

Closed StephanMa closed 2 years ago

StephanMa commented 2 years ago

PR for #1061 Will be tested

NTsch commented 2 years ago

Solves #1061, #563 and #1001.

StephanMa commented 2 years ago

Tested with Charter mom/AT-StiAWilten/Urkunden/001_B/charter resulted in...

1061 is fixed but #563 unfortunately not

StephanMa commented 2 years ago

Result of #1061 test

lgtm, but...

It looks kind of odd having a bulletpoint for material and not for seal

StephanMa commented 2 years ago

@NTsch would you please have a look?

yngwi commented 2 years ago

Result of #1061 test

lgtm, but...

It looks kind of odd having a bulletpoint for material and not for seal

I agree, the styling is inconsistent, would it be possible to get rid of the bullet points for all examples as it doesn't make sense if the seal doesn't have one and the other things (material, dimensions) do?

NTsch commented 2 years ago

Interestingly, the bullet point from the <li> shows up for me in Chrome, but not in Firefox, that's why I missed it. Yes, it should be list elements either everywhere or nowhere, I'll have another look. For cases like mom/AT-StiAWilten/Urkunden/001_B/charter, I could remove the "Siegel" text if it contains no text, like so: Screenshot from 2022-05-12 14-20-34 I'll do some tests with this.

NTsch commented 2 years ago

I've made a few changes, could you look at it again @StephanMa?

StephanMa commented 2 years ago

@NTsch LGTM

StephanMa commented 2 years ago

closes #563, #1001, #1061