search

icaruseu / mom-ca

Monasterium.net (http://www.monasterium.net/mom) - repository and collaborative archive
https://github.com/icaruseu/mom-ca/wiki
GNU General Public License v3.0
17 stars 11 forks source link

Some vocabularies do not suggest lemmas in editor #1064

Open NTsch opened 2 years ago

NTsch commented 2 years ago

When inserting a cei:index in the editor and selecting lemmas from a controlled vocabulary, a list of available lemmas should be created. This works for the IllUrk vocabulary and glossary, but not for the VID and VIS files. The reason seems to be that the name of the index is extracted from skos:conceptScheme/@rdf:about, and later used to identify the correct file via the atom:id - so it only works for vocabulary files in which the name in the atom:id and the skos:conceptScheme/@rdf:about/data() are identical.

GVogeler commented 2 years ago

Goal should be, that we can use any SKOS-Scheme: This means that the index app should be able to map the skos:conceptScheme/@about to the atom:id.

NTsch commented 2 years ago

From what I remember I've seen a few places in the code in which there is an implicit assumption that file name, atom:id and skos:conceptScheme/@rdf:about/data() are identical, and references are made from one to the other. Currently, this is in fact the case for all vocabulary files except VID, but it's not stated as a rule anywhere as far as I know. I've made some changes in the SKOS app to try and minimize this assumption. In any case, it would be good to keep this in mind when adding new SKOS files in the future.