search

icaruseu / mom-ca

Monasterium.net (http://www.monasterium.net/mom) - repository and collaborative archive
https://github.com/icaruseu/mom-ca/wiki
GNU General Public License v3.0
17 stars 11 forks source link

restore commas to cei:idno #1093

Closed NTsch closed 2 years ago

NTsch commented 2 years ago

Commas in cei:idno are currently removed in the single charter view by https://github.com/icaruseu/mom-ca/blob/master/my/XRX/src/mom/app/charter/xsl/cei2html.xsl#L1191. Displaying the comma is requested for the Fontenay collection, so this transformation should be removed unless a good reason for it emerges.

larkvi commented 2 years ago

Why is this desirable? What does a Fontenay msIdentifier look like?

GVogeler commented 2 years ago

<idno>15 H 17, pièce 1</idno>

GVogeler commented 2 years ago

I currently don't see a reason why the cei:idno would obligatorily exclude a comma.

GVogeler commented 2 years ago

And if so this should be enforced by schema not by transformation for display, shouldn't it?

larkvi commented 2 years ago

Agreed, but from a modelling perspective, is piece 1 really part of its shelfmark, or is it just an item in a box which has a shelf mark? I think it is less than ideal, and was curious. Off the top of my head, something like nested idnos 

<idno>
  Box Number
  <idno>
    piece order (do we not have an existing element for ordering?)
  </idno>
</idno>

would seem like a better solution, but again, that is a modelling question and has nothing, as you say, to do with he transformation.