search

icaruseu / mom-ca

Monasterium.net (http://www.monasterium.net/mom) - repository and collaborative archive
https://github.com/icaruseu/mom-ca/wiki
GNU General Public License v3.0
17 stars 11 forks source link

remove "search in this collection" slot in virtual collections #1172

Open GVogeler opened 10 months ago

GVogeler commented 10 months ago

mom-ca offers a general "search in this collection" widget in the collections / fonds menu. In aggregated collections like https://www.monasterium.net/mom/DO/collection and in collections with hooked-in charters this does not work as search uses the current collcetion/fonds identifier for constraint. Entry point to code: https://github.com/icaruseu/mom-ca/blob/8dc9a2b778c9e38765a5c9c4109ef157cfa9b710/my/XRX/src/mom/app/charters/widget/goto-search.widget.xml#L150-L160

GVogeler commented 10 months ago

There are probable two options:

  1. remove this slot in case of aggregated collections
  2. include a computed index methods (exist-trigger) to create an internal representation of these aggregationes

The second solution could also solve the problem with hooked-in charters, but it is a substantial effort. I would therefore prefer the first.