search

icastillejogomez / degiro-api

Unofficial DeGiro stock broker API. See your portfolio and set up orders in the market like wall street
MIT License
201 stars 30 forks source link

Added getPrice function #20

Closed danielvandenberg95 closed 2 years ago

danielvandenberg95 commented 3 years ago

In draft as enums are not complete yet. Basic features are in though.

danielvandenberg95 commented 3 years ago

https://github.com/icastillejogomez/degiro-api/issues/19

Chavithra commented 3 years ago

Hi there,

I see a hard coded "userToken" in the code.

You might want to remove that from the project history.

danielvandenberg95 commented 3 years ago

Hi there,

I see a hard coded "userToken" in the code.

You might want to remove that from the project history.

Thanks, done. I assumed/thought it was the same across every account as it still worked after I logged out. Should be removed.

bdoubleu86 commented 3 years ago

I am getting a Cross-Origin error.

Grund: CORS-Kopfzeile 'Access-Control-Allow-Origin' fehlt

Any idea?

danielvandenberg95 commented 3 years ago

I am getting a Cross-Origin error.

Grund: CORS-Kopfzeile 'Access-Control-Allow-Origin' fehlt

Any idea?

Hi bdoubleu86, please open a new issue next time instead of hijacking a completely different and unrelated issue. As for your problem, see https://github.com/icastillejogomez/degiro-api/issues/23.

SPecoul commented 3 years ago

Hi there,

I'm looking forward to this feature, and I was wondering what is preventing from accepting this P.R ? Does it have some remaining work to do ? How can we help to speed up the merge ? (sorry, I'm quite new to open source project)

icastillejogomez commented 3 years ago

@danielvandenberg95 did you review this code? How do you think about this PR?

martijndierckx commented 3 years ago

Hi all

This PR has been opened for quite some time. What needs to be done for it to be merged?