search

icastillejogomez / degiro-api

Unofficial DeGiro stock broker API. See your portfolio and set up orders in the market like wall street
MIT License
201 stars 30 forks source link

Fix: Get transactions missing types #39

Closed DennisSnijder closed 2 years ago

DennisSnijder commented 2 years ago

Context

Recently a new endpoint has been added to receive historical transactions. Only thing missing were the generated types.

What has been done

DennisSnijder commented 2 years ago

@icastillejogomez @danielvandenberg95 any idea why it might be failing? It's simply a build from the source, nothing else has been edited...

icastillejogomez commented 2 years ago

@danielvandenberg95 the linter is failing

danielvandenberg95 commented 2 years ago

Seems like the library has not been complying to it's own lint rules for a while now. All the errors outputted by the linter are valid, albeit not in files changed by this PR. Ignoring them for this PR sounds like a valid option to me.

Non-compliant files are:

DennisSnijder commented 2 years ago

@danielvandenberg95 @icastillejogomez Want me to fix the linting issues on this PR? Or do you suggest moving that to another PR?

danielvandenberg95 commented 2 years ago

I'll approve this PR as it looks good. A separate issue has been created for the linting.

danielvandenberg95 commented 2 years ago

If you'd like, of course you're more than welcome to fix the linting issues on a different PR! :smile: