Changes to SampleType - Githubissues

icatproject / icat.server

The ICAT server offering both SOAP and "RESTlike" interfaces to a metadata catalog.

Other

1 stars 5 forks source link

Changes to SampleType #239

Closed agbeltran closed 5 months ago

agbeltran commented 4 years ago

The ICAT model has SampleType but, as discussed in the ICAT collaboration meeting on 2nd July 2020, some changes are needed:

make molecularFormula optional, and thus can be NULL and should be removed from the uniqueness constraints
add description field

agbeltran commented 4 years ago

We also discussed that the relationship between SampleType and Facility needs more discussion, and it could be potentially be removed.

RKrahl commented 3 years ago

Agree with the proposed changes.

Additionally I suggest to make the molecularFormula attribute a bit wider, e.g. change it to String [1023]. The idea would be to also allow using an InChI (e.g. InChI=1S/C2H6O/c1-2-3/h3H,2H2,1H3 for ethanol) in the place of a plain molecular formula. While I assume that most InChIs would fit into 255 characters, it may get tight for some. Accordingly we should also adapt the description of molecularFormula to hint for the InChI option.

RKrahl commented 5 months ago

Even though in truth, it's the other way round: #326 has been submitted despite this one already exists, so #326 should be considered the duplicate, I still suggest to close this one as duplicate of #326, because the latter corresponds to the latest version of the proposal.