search

icatproject / icat.server

The ICAT server offering both SOAP and "RESTlike" interfaces to a metadata catalog.
Other
1 stars 5 forks source link

Should ICAT quit if it doesn't recognise the application server? #257

Open stuartpullinger opened 2 years ago

stuartpullinger commented 2 years ago

Because the code to recognise the application server (container type) fails when run in Payara's provided docker image (see icatproject/icat.utils#15), icat.server stopped rather than continue in an unknown application server. Is this really the behaviour we want? Given that there a many different application servers, should it really require a change to the code to try icat.server on a previously unknown application server? Perhaps this line should be changed to just log a WARNING that the current application server is not recognised and, therefore, may be unstable?

What does @ajkyffin think?

ajkyffin commented 2 years ago

I think the only place that the containerType gets used is the /properties REST endpoint: https://github.com/icatproject/icat.server/blob/f86b255fc7ab43cdcb55876b57966c22ff39b08a/src/main/java/org/icatproject/exposed/ICATRest.java#L477 so there is no need to quit if it is unknown. I don't think a warning is necessary either.