Fix duplicate calls of mainStorage.lock() in LockManager for version 1.*

icatproject / ids.server

The server component of the ICAT Data Service

Other

3 stars 3 forks source link

Fix duplicate calls of mainStorage.lock() in LockManager for version 1.* #165

Closed RKrahl closed 2 months ago

RKrahl commented 4 months ago

store the storage lock in class LockEntry rather than in class SingleLock,
as a consequence: obtain only one storage lock when mutliple shared locks are requested on the same dataset,
release the storage lock when the lock count drops to zero, e.g. when the last lock on the dataset is closed.

This fixes #164 for ids.server version 1.*.

RKrahl commented 4 months ago

Note: the CI build and test pipeline fails. But that looks like the icat-ansible ceased to support the old Java version used to build v1.*. The test succeed when I run them locally.