icatproject / topcat

GUI to work with multiple ICAT and IDS servers.
Other
1 stars 9 forks source link

Cancelling a recall does not stop the IDS requesting data #406

Open ChrisProsserSTFC opened 5 years ago

ChrisProsserSTFC commented 5 years ago

When a user deletes a recall via TopCAT (that they have presumably made in error) this appears to do nothing more than mark the recall as deleted in the TopCAT UI/download table. The IDS continues to ask the storage for the data which can be problematic if the requested recall was several TB / 100,000s of files. Can this behaviour change i.e. a delete stops the recall in its tracks?

For information : This issue was discussed previously in 'Ability to cancel a download/restore #152' but was closed.

Many thanks, Chris

brianritchie1312 commented 5 years ago

As Stuart points out, there's no mechanism in IDS at present to cancel a preparedId (for a download/recall), so there is nothing Topcat can do to cancel the download. I'm slightly surprised to see that Topcat's StatusCheck monitor does not use the 'isDeleted' flag in downloads, so will continue to check their progress. (If it didn't, then any view that shows deleted downloads might mis-report their status.) If an API is added to ids.server to cancel a preparedId then StatusCheck will probably have to change either to use it or to take "truly cancelled" downloads into consideration. We may need a new DownloadStatus value as well.