search

icatproject / topcat

GUI to work with multiple ICAT and IDS servers.
Other
1 stars 8 forks source link

Improve logging in StatusCheck timer #436

Closed brianritchie1312 closed 4 years ago

brianritchie1312 commented 5 years ago

StatusCheck.poll() currently catches and logs any Exceptions; but logs only the original message. It would be more useful if it added a more specific indication to the message. Similarly, determining the cause of an expunged timer thread in glassfish can be difficult. I propose adding a catch-log-and-rethrow for all other Throwables. This is not considered good practice generally, but may improve traceability. See also: https://github.com/icatproject/icat.utils/issues/8#issuecomment-498282193

brianritchie1312 commented 5 years ago

I stand corrected on the first part of this: errors logged to topcat.log do indicate that they are from StatusCheck; so there is no need to add extra text to the log message. I have some evidence that suggests they still count as failures that may trigger glassfish to expunge the timer.

brianritchie1312 commented 5 years ago

8d7984c9 added logging to StatusCheck to record prepareData and isPrepared requests on the IdsClient and any resulting changes to Download status.