search

iccanobif / gikopoi2

37 stars 17 forks source link

fix log dates #489

Closed miezak closed 1 year ago

miezak commented 1 year ago

frontend can (optionally?) stop repeating open bubbles with this new info as well.

iccanobif commented 1 year ago

can you explain more clearly what this PR is trying to fix?

iccanobif commented 1 year ago

Okay, I read the code... Now when you enter a room and there are bubbles open, in the log you see the current date instead of the date in which the bubble was opened. It was actually made like this on purpose: it's a sort of privacy feature in the sense that when you enter a room, you can't see any information about what happened before you went in. To put it in another way, if user A opens a bubble while user B is not in the room, even when B logs in no extra information about A is leaked except for what they explicitly chose to expose by leaving the bubble open (that is, only its content), so B can't tell when A was active: they only see that A opened a bubble at an unspecified time in the past.

miezak commented 1 year ago

fair enough, I didn't know it was an intentional thing.

it's a sort of privacy feature

how about User.lastMovement?