search

iccm-africa / iccm-backend

The International Conference on Computing and Mission (ICCM) Backend System
https://iccm.africa
GNU Affero General Public License v3.0
2 stars 4 forks source link

WIP: Add Rest API #17

Closed phox4ever closed 1 year ago

phox4ever commented 1 year ago

@tpokorra @AlbertJP I wrote to my lecturer, and he said I'm free to use whatever framework and language I want for my assignment. So I can put in some more work into this over the following weeks as part of passing my advanced web technology class. I may have to update the Readme, code style and do some refactoring of the existing code to meet all the requirements of the assignment, though.

ruliezz commented 1 year ago

@phox4ever we have not met yet in real, but Im very glad with hearing this! That would give our project a boots!

tpokorra commented 1 year ago

@phox4ever wow, this is good news! I guess make multiple smaller pull requests for README and code style and refactoring, that way it will be easier for @ruliezz to review and to merge.

phox4ever commented 1 year ago

@ruliezz I tried to mark this PR as WIP to indicate it's not ready to be merged. The API has not yet been locked down sufficiently for the API to be released in its current state, and is far from finished. I would revert the changes if you can.

EDIT: Updated my comment as it could be misunderstood...

ruliezz commented 1 year ago

@phox4ever this can be said more kindly.... it's not a big deal, since I do not think anybody else apart from us are using this code.

@AlbertJP are you able to help me with this?

phox4ever commented 1 year ago

@ruliezz I'm sorry, I did not intend to sound harsh. I was just surprised it got merged and worried about the consequences. I'm not familiar with GitHub, and thought PRs marked as WIP can't be merged like in GitLab.

Edit: Looks like I need admin access for this: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/about-pull-requests#draft-pull-requests