search

icculus / ControllerImage

A library for producing images of SDL controllers.
zlib License
107 stars 2 forks source link

Added keyboard and mouse support, variantIDs, and ordinary theme #31

Closed ShockSlayer closed 2 months ago

ShockSlayer commented 2 months ago

Normally I would have liked to separate these concepts into separate commits, but I wrote variants before keyboard and mouse support, and I've only got variants set up for the "ordinary" theme for controllers. Additionally, "kenney" must be loaded to have any usable graphics for keyboard and mouse support. It might not be a bad idea to see about fleshing out those graphics to capture anything missing in comparison to the "standard" set, and making that the standard instead.

I never actually set up the demos, but I have modified them as well as the readme to reflect the API changes. Hopefully there are no issues there.

icculus commented 2 months ago

Why did you close this?

ShockSlayer commented 2 months ago

I didn't hear back on this or the issue, so I figured it actually was out of line with the design philosophy, and it felt weird to just leave it up. I don't usually make pull requests so I'm not sure what proper protocol is for this type of situation.

Otherwise, this is still code I'm using locally, and I haven't detected any further issues with it.

icculus commented 2 months ago

I haven't looked at it yet, I've been in crunch on another project.

I'll take a look at this soon, if you don't mind waiting a little longer!

ShockSlayer commented 2 months ago

No worries, I'm just relieved to know I wasn't being ignored. Looking forward to hearing your thoughts!