search

icculus / Serious-Engine

An open source version of a game engine developed by Croteam for the classic Serious Sam games.
GNU General Public License v2.0
164 stars 21 forks source link

Asm fixes #39

Closed notaz closed 8 years ago

notaz commented 8 years ago

In release build asm is crashing all over the place, turns out it has many issues. If GNU_INLINE ever worked I'd be very surprised, was the original Linux port released with that enabled? Anyway it's fine now for me after these patches.

icculus commented 8 years ago

If GNU_INLINE ever worked I'd be very surprised, was the original Linux port released with that enabled?

It was, and it did work, but gcc 2.95 was a very different compiler than today's versions. :)

icculus commented 8 years ago

(For example, "memory" in the clobber list basically told GCC to assume all registers are ruined, apparently that isn't the case now, based on https://github.com/rcgordon/Serious-Engine/pull/39/commits/cb69bd3cdd603c837865447d0c2743bcc75843fc

I'm reviewing this quickly before I merge it, sit tight a second.

icculus commented 8 years ago

Ok, wow, that looked like a lot of unfun work to clean that up. I'm really impressed! Merging!