search

icculus / Serious-Engine

An open source version of a game engine developed by Croteam for the classic Serious Sam games.
GNU General Public License v2.0
164 stars 21 forks source link

Fix ModEXT.txt issues #49

Closed yamgent closed 8 years ago

yamgent commented 8 years ago

Creating a ModExt.txt symlink to ModEXT.txt is a bad idea for filesystems that does not support files having the same name with different casing. symlink is also not compatible with Windows anyway.

Instead the root of the problem is fixed by modifying the code to load the correct file.

DanielGibson commented 8 years ago

I think this makes sense. :+1:

yamgent commented 8 years ago

Anything wrong with the PR?

icculus commented 8 years ago

Anything wrong with the PR?

Nope, sorry for the delay!

--ryan.

DanielGibson commented 8 years ago

hmm I just noticed that in my serious sam installation, the file actually seems to be called ModExt.txt, not ModEXT.txt. We should find a way to support both (unfortunately, LoadStringVar() doesn't return if it was successful)

DanielGibson commented 8 years ago

ok, supporting both wasn't that hard after all, added a fix to #56