icculus / mojoshader

Use Direct3D shaders with other 3D rendering APIs.
https://icculus.org/mojoshader/
zlib License
122 stars 36 forks source link

CMake is looking for `../Vulkan-Headers/` #46

Closed icculus closed 2 years ago

icculus commented 3 years ago

Can we look for these in a standard place, or just include them with the MojoShader sources?

flibitijibibo commented 3 years ago

Will page @thatcosmonaut in case he's aware of any known trick, but the source of this is us simply including Vulkan-Headers in the parent project:

https://github.com/FNA-XNA/FNA3D

Bundling the headers directly can cause conflicts with the renderer that uses MojoShader, and unlike GL/ the headers for Vulkan are... kind of huge.

I would suggest:

thatcosmonaut commented 3 years ago

I agree with that strategy.

flibitijibibo commented 2 years ago

Fixed via https://github.com/icculus/mojoshader/commit/9bfd475023e7ca74568fd105ebad3e33195f2aab