MOJOSHADER_spirv_link_attributes performs some postprocessing operations on the SPIR-V content to rearrange and match up vertex output and pixel input. This is necessary for cross-stage linkage, and it works for Vulkan and OpenGL. However, when using SPIRV-Cross to transpile the emitted SPIR-V into HLSL, there are certain relocations that produce invalid HLSL. Specifically, the dedicated logic for COLOR attributes results in vertex outputs/pixel inputs with "holes" in them, which will cause link errors when compiling the HLSL.
This PR disables the COLOR attribute relocation logic on non-glspirv profiles. The logic was added specifically for OpenGL 4.6 SPIR-V support in the first place, so it's unnecessary on other profiles anyway. (In fact, it may be unnecessary even with glspirv -- all my tests seemed to run as expected with all of the color relocation disabled! But just for safety, we'll keep it for now.)
MOJOSHADER_spirv_link_attributesperforms some postprocessing operations on the SPIR-V content to rearrange and match up vertex output and pixel input. This is necessary for cross-stage linkage, and it works for Vulkan and OpenGL. However, when using SPIRV-Cross to transpile the emitted SPIR-V into HLSL, there are certain relocations that produce invalid HLSL. Specifically, the dedicated logic for COLOR attributes results in vertex outputs/pixel inputs with "holes" in them, which will cause link errors when compiling the HLSL.This PR disables the COLOR attribute relocation logic on non-
glspirvprofiles. The logic was added specifically for OpenGL 4.6 SPIR-V support in the first place, so it's unnecessary on other profiles anyway. (In fact, it may be unnecessary even withglspirv-- all my tests seemed to run as expected with all of the color relocation disabled! But just for safety, we'll keep it for now.)