search

ice-cream-the-fat-cat / my-niwa-frontend

0 stars 3 forks source link

add store confirm flow #202

Closed yukari-n-erb closed 3 years ago

yukari-n-erb commented 3 years ago

Description

Added purchase confirm dialog to prevent spam on store page.

Closes issue(s)

194

How to test / reproduce

Screenshots

Screen Shot 2021-09-13 at 22 50 49 Screen Shot 2021-09-13 at 22 50 54 Screen Shot 2021-09-13 at 22 51 06

Changes include

Checklist

Other comments

I'm not confidence of this menu's layout UI, so please let me know if there are more improve point.

netlify[bot] commented 3 years ago

👷 Deploy request for myniwa-staging pending review. Visit the deploys page to approve it

🔨 Explore the source changes: 032041184838b6250dcf8bc34fc318af7ed78962

yukari-n-erb commented 3 years ago

@daiHash As we discuss, I added a purchase dialog in other component file. 🙏

Screen Shot 2021-09-14 at 21 25 17 Screen Shot 2021-09-14 at 21 25 21 Screen Shot 2021-09-14 at 21 25 24

Honestly, I'd like to remove floristStep, but I don't come up a idea to do this...😅

yukari-n-erb commented 3 years ago

memo : improve UI point (talked with Daichi)

daiHash commented 3 years ago

When finished if you can share a gif of the whole flow it'd be nice and easier to check

yukari-n-erb commented 3 years ago

@daiHash I fixed not only layout change but also your code reviewing point. 🙏

Screen Shot 2021-09-15 at 21 09 38

Sep-15-2021 20-48-44

yukari-n-erb commented 3 years ago

Thank you for reviewing! To add coin icon, I'd like to work as other issue https://github.com/ice-cream-the-fat-cat/my-niwa-frontend/issues/214 .

I've fix term and remove "".

Screen Shot 2021-09-16 at 20 21 40
yukari-n-erb commented 3 years ago

@daiHash I resolved conflicts, so could you review this for merging? 🙏