search

ice-cube-ruby / ice_cube

Ruby Date Recurrence Library - Allows easy creation of recurrence rules and fast querying
MIT License
2.41k stars 358 forks source link

Psych::DisallowedClass: Tried to load unspecified class: Time with Psych v4 #520

Closed jeffblake closed 2 years ago

jeffblake commented 2 years ago

On psych 4.0, the following error is raised:

Psych::DisallowedClass: Tried to load unspecified class: Time

After accessing a serialized schedule on an AR model, such as:

serialize :schedule, IceCube::Schedule

Works fine with Psych 3.3.2

pacso commented 2 years ago

Hey @jeffblake, this sounds very much like an issue with Psych 4.0 rather than IceCube.

I'm not sure what you're expecting us to do with this? If you have a failing test for this gem, or a change you want to suggest, then please submit a PR.

jeffblake commented 2 years ago

Hi @pacso Here's an example fix: https://github.com/sparklemotion/mechanize/pull/589/files

https://github.com/ruby/psych/issues/503

pacso commented 2 years ago

Hi again @jeffblake

I've created a new PR for the latest Ruby, and have replicated the issue you've mentioned. Thanks for pointing it out ... will get a fix sorted before the next release.

pacso commented 2 years ago

@jeffblake - could you possibly test with the branch from PR #521 please?

jeffblake commented 2 years ago

@pacso My tests pass! Thanks.

pacso commented 2 years ago

Great, thanks for checking! I'll merge it now :)

Aesthetikx commented 2 years ago

Can we get a rubygems release for this? ❤️

gustavompo commented 2 years ago

+1 for a release

jeffblake commented 2 years ago

Bump for release please.

pacso commented 2 years ago

Hey everyone.

We have a problem in terms of cutting a release at the moment. One of the previous commits fixed a bug, but introduced another. By rolling it back we remove the new bug, but reintroduce the old one. Neither is a viable option really.

I've been struggling for time recently, but should be able to dedicate myself to fixing this soon. Once done we'll cut a new release and get both bugs sorted properly.

Sorry for the delay!

adfoster-r7 commented 8 months ago

It would be great if there was a release available for this; is there anything I can do to help? 🤞