search

ice-wm / icewm

IceWM releases only, see Wiki
https://github.com/ice-wm/icewm/releases
Other
289 stars 16 forks source link

allow icons for Logout entry and Cancel entry on Logout sub-menu #69

Closed Corin-EU closed 2 years ago

Corin-EU commented 2 years ago

Provided that suitably named icons are present on the IconPath, the appropriate icon appears on the menu entry in the taskbar+desktop menu. However, the first two entries of the Logout sub-menu do not currently allow an icon to be used and this does look rather untidy if all the other entries have an icon.

By simply adding the icon name (logout and cancel-logout) as the currently unspecified fifth parameter to the addITem function calls on lines 494 and 495 of wmapp.c

          addItem(_("_Logout"), -2, null, actionLogout, "logout");
          addItem(_("_Cancel logout"), -2, null, actionCancelLogout, "cancel-logout")->setEnabled(false);

the blank icon area on the sub-menu can be filled with the appropriate icon image.

Maybe in the future, icon entries could also be enabled for the Window operations menu.

Corin-EU commented 2 years ago

Thank you for the very quick response.