ice-wm / icewm

IceWM releases only, see Wiki
https://github.com/ice-wm/icewm/releases
Other
286 stars 15 forks source link

Problems fullscreening wine programs in icewm 2.9.0 #73

Closed plomari closed 2 years ago

plomari commented 2 years ago

Since icewm 2.9.0, fullscreening wine programs (a game) doesn't make the taskbar disappear. Also, there are weird focus issues. I also see tearing, but this is probably because the driver doesn't recognize the game's window as fullscreened anymore. It was fine before icewm 2.9.0 (not sure which version exactly, but I'm using Debian unstable).

gijsbers commented 2 years ago

Debian unstable upgraded to 2.9.1. Does that help you? If not, can you recommended a minimal tiny application for me which repeats this behavior? (i don't wish to install game hoopla.)

plomari commented 2 years ago

I just tried 2.9.1. It's possible that it improved behavior somewhat, but it's still bad. Before 2.9.0:

With 2.9.0:

With 2.9.1:

plomari commented 2 years ago

Actually, the focus problems are gone with 2.9.1 too, just the taskbar visibility is broken. I just saw the commit referencing this commit, I can try tomorrow or so.

plomari commented 2 years ago

Tried it now, using commit 0ea5a3c5cba86e9b9609614fc1dd013e03fc909c. I can confirm that this seems to have fixed the fullscreen issues I reported in this issue.

plomari commented 2 years ago

Could it be that this bug was fixed with 2.9.2, but appeared again with 2.9.3?

gijsbers commented 2 years ago

It carries a different solution, which was intended to be at least equivalent, but if it fails, please provide me with a scenario that I can reproduce on my system using my wine installation. For example, wine comes with executables like notepad and wordpad and so on. Can you detail a reproducable scenario with that?

plomari commented 2 years ago

OK, I don't know how to make standard wine programs enter fullscreen, but here's a reproduction with a freely available game:

gijsbers commented 2 years ago

Perfect scenario! Here the focus was set to a subwindow, which was a new case. Works for me in fullscreen now. There is still the bug that sometimes the taskbar won't go away when the game is in fullscreen. Someday...

ghost commented 1 year ago

Notice this issue in icewm 3.0.1 on FreeBSD

gijsbers commented 1 year ago

@hunter2k01 The same game? How to repeat it?

ghost commented 1 year ago

@hunter2k01 The same game?

No, I am using WINE Steam (through Suyimazu) and in the first game I've installed which is Team Fortress Classic the taskbar appears above the fullscreen window even in fullscreen mode.

Install Suyimazu and you can install Steam through the GUI or with "Suyimazu Install Steam". Run a GoldSrc game like Half-Life (TFC in my case) and it should have the same effect.

plomari commented 1 year ago

3.0.1 doesn't seem to show any fullscreen regressions in my case.

gijsbers commented 1 year ago

It seems to depend on particulars of some wine apps. Wine uses a special focus model. The taskbar fullscreen code is hairy. To make progress, report on percentage of reproducability (reliability of occurrence) and give the output of the icesh focusmodel command.

plomari commented 1 year ago

I get "Globally" on my wine apps, if that matters.

gijsbers commented 1 year ago

Indeed and wine is the only one I know of. It could be helpful to learn if other "Globally" apps have the same fullscreen problem. That would make testing easier too.

gijsbers commented 1 year ago

This fixes the problem for me. Can you test if this works for you too?

zaza42 commented 1 year ago

Wow, this solved the problem of fullscreen mpv, which also sometimes forgot the taskbar at the bottom. (Before that I used an always on top from script after every switch to fullscreen.) I think this is the same bug, because it started with version 2.9.0.

gijsbers commented 1 year ago

If it is the same bug, then icesh -c mpv focusmodel should output "Globally".

zaza42 commented 1 year ago
$ icesh -c mpv focusmodel
0x6000002  focusmodel Passive