Router, refactor

[Yahasana]

make it faster, robust and full features.

one more thing: the old router was renamed to FastRouter. feel free to inject it into di by hand.

[Yahasana]

@mruz new implement for route done. do you have script to test it performance with other routers?

[mruz]

A good piece of work, thanks! I don't have, but we could use the ones form tests in the 1000 loop.

[mruz]

@Yahasana is it possible to have a static route the same as placeholder?

['GET', '/contact', ['controller' => 'index', 'action' => 'contact']],
['GET', '/{controller}', ['controller' => '[a-z]+[/]?']],

I tired with {action} too, but it's not working.

[Yahasana]

please check comments in Router::setRoutes L164

// the rule format: ['name' => ["httpMethod", "URI pattern", "regex", "defaults"]]

// there is no placeholder for static route, so regex is null
['GET', '/contact', null, ['controller' => 'index', 'action' => 'contact']]

[mruz]

It works, thanks. Is it a bug that

['GET', '/{action}', ['action' => '[aboutus|policy|terms|contact]+']],

matches /user too?

[Yahasana]

nope, do you add other route rules?

['GET', '/{action}', ['action' => '[aboutus|policy|terms|contact]']],

[mruz]

Yes, /{controller} as I sent before.

[Yahasana]

so /user will match the rule

['GET', '/{controller}', ['controller' => '[a-z]+[/]?']],

[mruz]

Routes

            ['GET', '/{module}', ['module' => '[admin|doc]+']],
            ['GET', '/{action}', ['action' => '[aboutus|policy|terms|contact]+'], ['controller' => 'index']],
            ['GET', '/{controller}', ['controller' => '[a-z]+[/]?']],

Tests

            ['/contact', ['frontend', 'index', 'contact', []]],
            ['/admin', ['admin', 'index', 'index', []]],
            ['/user', ['frontend', 'user', 'index', []]],

Result

1) Tests\RoutesTest::testUniversalGET with data set #2 ('/user', array('frontend', 'user', 'index', array()))
/user
Failed asserting that two arrays are equal.
--- Expected
+++ Actual
@@ @@
 Array (
     0 => 'frontend'
-    1 => 'user'
-    2 => 'index'
+    1 => 'index'
+    2 => 'user'
     3 => Array ()
 )

[mruz]

ok, it should be:

['GET', '/{module}', ['module' => 'admin|doc']],
['GET', '/{action}', ['action' => 'aboutus|policy|terms|contact']],
['GET', '/{controller}', ['controller' => '[a-z]+[/]?']],

thanks!

[Yahasana]

controller should NOT contain /

['GET', '/{controller}', ['controller' => '[a-z]+']],

['GET', '/{controller}[/]', ['controller' => '[a-z]+']],