search

ice / framework

Source code of Ice framework
https://www.iceframework.org
BSD 3-Clause "New" or "Revised" License
341 stars 45 forks source link

Windows build of ice 1.6.0 fails due to CREDITS #267

Closed cmb69 closed 4 years ago

cmb69 commented 4 years ago

The CREDITS file in ice-1.6.0 has the following contents:

Mariusz Laczak [mruz] <mruz@php.net> (lead)

This breaks the build on Windows, because the < and > are not escaped, and as such are treated as redirection signs. It might be argued that the PHP-SDK should cater to this escaping, but usually there are no special characters contained in CREDITS.

Furthermore, the first line of CREDITS should contain the name of the package.

So I suggest to change CREDITS to

Ice Framework
Mariusz Laczak

PS: it's not about the PHP-SDK, but rather the build system of https://github.com/php/php-src/.

mruz commented 4 years ago

Thanks! I will change.

mruz commented 4 years ago

I have a small patch, so will fix CREDITS in the 1.6.1 release. Just wonder how _PEARPackageFileManager2 will update the changelog in the package.xml. I used it for the first version release on pecl. If it doesn't work I will add the changelog manually.