search

ice1000 / jimgui

:sparkling_heart: Pure Java binding for dear-imgui
Apache License 2.0
186 stars 13 forks source link

Exposing protected methods in JImGuiGen #42

Open Mr00Anderson opened 5 years ago

Mr00Anderson commented 5 years ago

I would like to expose JImGuiGen methods that are private / protected which take native parameter. After a bit of work and work around/efficiencies and nothing really great in terms of generics issues between a String or JImStr, just would be easier to store it as its original intended API type byte[].

This would open up your API easier to anyone to extend it without making PRs as well.

Edit: With this opening up the classes with a long pointer too to enable usage of those with API that has a byte[] but also takes a pointer/long. With getters, or direct access.

ice1000 commented 5 years ago

How about exposing a JImStr::new(byte[] bla)?

ice1000 commented 5 years ago

The APIs are protected only because I wanted to use them in the JImGui class, otherwise they should be private. I'm recommending JImStr::new(byte[] bla) since it's not much different from exposing the byte[] API.