ice1000 / jimgui

:sparkling_heart: Pure Java binding for dear-imgui
Apache License 2.0
185 stars 13 forks source link

Build for macOS broken since ImGuiFileDialog also broken for macOS #85

Open gerald24 opened 2 years ago

gerald24 commented 2 years ago

Since 15 Feb 2022 build for ImGuiFileDialog is broken for macOS

Screenshot 2022-08-21 at 08 52 10

after changing build.gradle.kts line 147 to 162, so that commits from 20 Jan are used:

the build succeeded successful.

val downloadDirent = tasks.register<Download>("downloadDirent") {
  src("$imguiFD/ce5edcbf10748292609f971372d7b8e64230e97b/dirent/dirent.h")
  dest(fdDir.resolve("dirent").resolve("dirent.h"))
  overwrite(false)
}

val downloadFileDialog = tasks.register<Download>("downloadFileDialog") {
  group = downloadGroup
  if (isWindows) dependsOn(downloadDirent)
  src("$imguiFD/87cd5def54ac0cc2952df63d98a8dbbae714e88d/CustomFont.h")
  src("$imguiFD/87cd5def54ac0cc2952df63d98a8dbbae714e88d/CustomFont.cpp")
  src("$imguiFD/ce5edcbf10748292609f971372d7b8e64230e97b/ImGuiFileDialog.h")
  src("$imguiFD/ce5edcbf10748292609f971372d7b8e64230e97b/ImGuiFileDialog.cpp")
  dest(fdDir)
  overwrite(false)
}

Environment:

Gradle 7.4.1
Kotlin:       1.5.31
Groovy:       3.0.9
Ant:          Apache Ant(TM) version 1.10.11 compiled on July 10 2021
JVM:          17.0.2 (Oracle Corporation 17.0.2+8-86)
OS:           Mac OS X 12.5.1 aarch64

cmake version 3.24.1
glfw: stable 3.3.8
ice1000 commented 2 years ago

I am expecting imfiledialog's failure to build on macos to be a bug of theirs. I think they should fix it and we follow up.

I'm not making any releases lately, so using the latest release version should be fine.

Or do you have to build jimgui yourself?

gerald24 commented 2 years ago

I don't expect it to be fixed in jimgui. I just wanted to point it out in case anyone else has the problem.

Btw. thanks for jimgui :-)

ice1000 commented 2 years ago

I don't expect it to be fixed in jimgui. I just wanted to point it out in case anyone else has the problem.

Btw. thanks for jimgui :-)

With project panama I hope we won't need binding libraries anymore. RIP jimgui.

ice1000 commented 2 years ago

And btw, you're welcome :-)

aiekick commented 1 year ago

Hello,

the issue i have as i know about macos is just related to github actions. i not found a proper way for it.

if imgui is working and even you have dirent.h or using std::filessytem for c++17, there is no well known issue about macos, as you can see all errors are related to imgui, so jsut a bad configuration for macos it seems. maybe just a version of gcc + libs as usual with mac.. https://github.com/aiekick/ImGuiFileDialog/actions/runs/2538776825/jobs/3898093386

but if you have some feedback, plase share :)