Closed bismarck2100 closed 7 years ago
Nice catch, thanks!
Hovever, I'm not sure how this is supposed to fix that? It looks like you moved the condition up from inside AceJumpCommand.jump
to where it is called, which shouldn't really change anything since it was the first thing inside the method.
Please correct me if I'm missing something.
Thanks for quick reply~
In my opinion, it's because AceJumpCharCommand override the jump function.
When "jump" function is called in AceJumpCommand.submit
, AceJumpCharCommand.jump
will be invoked.
Thanks.
Oh right, that makes sense. Thanks a lot!
I found that when using char mode, user will get an error after pressing esc without enter any target char. root cause: should check self.target before performing jump in char mode. Thanks.