search

iceberg-project / ICEBERG-middleware

This repo contains the ICEBERG middleware as it is agreed by the members of the ICEBERG project.
MIT License
2 stars 1 forks source link

Feature/seals support #14

Closed iparask closed 5 years ago

iparask commented 5 years ago

This PR introduces the full support of the Seals use case. The package will install RADICAL Ensemble Toolkit. To execute the seals use case the following command will be executed:

iceberg -r xsede.bridges -q GPU-small -c 32 -g 2 -ip <path>/SealsImages -op ./ -w 30 -p mc3bggp seals -s 299 -m UnetCntWRN_ts-vanilla.tar -mp <path>/UnetCntWRN/ -hy A -ma UnetCntWRN

All paths need to be set per user.

codecov[bot] commented 5 years ago

Codecov Report

Merging #14 into devel will decrease coverage by 5.65%. The diff coverage is 29.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##            devel      #14      +/-   ##
==========================================
- Coverage   43.92%   38.26%   -5.66%     
==========================================
  Files           8        8              
  Lines         214      277      +63     
==========================================
+ Hits           94      106      +12     
- Misses        120      171      +51
Impacted Files Coverage Δ
src/iceberg/iceberg_parser/iceberg_parser.py 0% <0%> (ø) :arrow_up:
src/iceberg/discovery/discovery.py 100% <100%> (ø) :arrow_up:
src/iceberg/discovery/image_disc.py 73.07% <100%> (+2.24%) :arrow_up:
src/iceberg/executor/executor.py 85.71% <100%> (+3.1%) :arrow_up:
src/iceberg/executor/seals.py 14.94% <7.14%> (-12.34%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8d27780...dea2e44. Read the comment docs.

AymenFJA commented 5 years ago

I tried to execute the following command :

iceberg --resource xsede.bridges  --queue RM --cpus 28 --gpus 1 --input_path /home/seals/ --output_path /home/seals/ --walltime 60 --project mc3bggb --analysis seals

and i am getting the following error :

usage: iceberg [-h] --resource RESOURCE [--queue QUEUE] --cpus CPUS --gpus
               GPUS --input_path INPUT_PATH --output_path OUTPUT_PATH
               --walltime WALLTIME [--project PROJECT]
               {seals,penguins,4Dgeolocation,rivers,landcover} ...
iceberg: error: unrecognized arguments: --analysis

Am I doing something wrong?

iparask commented 5 years ago

Yes, there is no analysis flag anymore. Each use case is a command.

AymenFJA commented 5 years ago

I tried the following command : 

iceberg -r xsede.bridges -q GPU-small -c 32 -g 2 -ip <path>/SealsImages -op ./ -w 30 -p mc3bggp seals -s 299 -m UnetCntWRN_ts-vanilla.tar -mp <path>/UnetCntWRN/ -hy A -ma UnetCntWRN

and i can see that seals.0000 session is generated with EnTK log files.