search

iceberg-project / ICEBERG-middleware

This repo contains the ICEBERG middleware as it is agreed by the members of the ICEBERG project.
MIT License
2 stars 1 forks source link

Subparser easy addition change #24

Closed iparask closed 4 years ago

iparask commented 4 years ago

I removed all the sub parsers from the main class and added a class per sub parser. When a new sub parser of required a new class should be created that takes a parser as an argument.

Then that class should be imported and added to the PARSERS global dictionary

PARSERS = {'seals': SealsSubparser,
           'penguins': PenguinsSubparser,
           'rivers': RiversSubparser,
           'landcover': LandcoverSubparser}

The top level parser will pick it up and include it in all the commands.

This fixes #20

codecov[bot] commented 4 years ago

Codecov Report

Merging #24 into devel will decrease coverage by 1.33%. The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##            devel      #24      +/-   ##
==========================================
- Coverage   38.26%   36.93%   -1.34%     
==========================================
  Files           8       12       +4     
  Lines         277      287      +10     
==========================================
  Hits          106      106              
- Misses        171      181      +10
Impacted Files Coverage Δ
src/iceberg/iceberg_parser/penguins_parser.py 0% <0%> (ø)
src/iceberg/iceberg_parser/seals_parser.py 0% <0%> (ø)
src/iceberg/iceberg_parser/landcover_parser.py 0% <0%> (ø)
src/iceberg/iceberg_parser/rivers_parser.py 0% <0%> (ø)
src/iceberg/iceberg_parser/iceberg_parser.py 0% <0%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 887f84b...9b6585a. Read the comment docs.