search

iceberg-project / ICEBERG-middleware

This repo contains the ICEBERG middleware as it is agreed by the members of the ICEBERG project.
MIT License
2 stars 1 forks source link

Feature/cli #4

Closed iparask closed 5 years ago

iparask commented 5 years ago

This PR is for the argument parser of the ICEBERG middleware. There are a couple of important points.

  1. It introduces a single executable for invoking ICEBERG capabilities
  2. Creates an ICEBERG package which can be installed via pip.
  3. It starts to have continuous integration with Travis. It fails currently because, I've been unable to devise a unit test for the parser. This remains as todo.

It closes issue #3

bspitzbart commented 5 years ago

I get:

(iceberg) [bspitzbart@login1 ICEBERG-middleware]$ pip install . --upgrade
Processing /gpfs/scratch/bspitzbart/ICEBERG-middleware
    Complete output from command python setup.py egg_info:
    Traceback (most recent call last):
      File "<string>", line 1, in <module>
      File "/tmp/pip-req-build-5foeakjz/setup.py", line 224, in <module>
        'data_files'         : df,
    NameError: name 'df' is not defined

    ----------------------------------------
Command "python setup.py egg_info" failed with error code 1 in /tmp/pip-req-build-5foeakjz/
bspitzbart commented 5 years ago

There is a typo in setup.py 'author_email' : 'icberg-ci@googlegroups.com'

AymenFJA commented 5 years ago

The error is replicable :

Processing /home/aymen/ICEBERG-middleware
Complete output from command python setup.py egg_info:
Traceback (most recent call last):
File "<string>", line 1, in <module>
File "/tmp/pip-req-build-N4Lk9N/setup.py", line 224, in <module>
'data_files'         : df,
NameError: name 'df' is not defined

My environment :

Python 2.7.15
Anaconda
iparask commented 5 years ago

Aha! I think you did not checkout the feature/cli branch before you installed. It is true that the setup.py under devel has issues. Having said that, thank you @bspitzbart for catching the typo. It was still there!

bspitzbart commented 5 years ago

Ah yes. I blindly followed the README. It built successfully under feature/cli. It looks really neat, I will try some more tests.

On Wed, Apr 3, 2019 at 5:16 PM Ioannis Paraskevakos < notifications@github.com> wrote:

Aha! I think you did not checkout the feature/cli branch before you installed. It is true that the setup.py under devel has issues. Having said that, thank you Brad for catching the typo. It was still there!

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub https://github.com/iceberg-project/ICEBERG-middleware/pull/4#issuecomment-479662092, or mute the thread https://github.com/notifications/unsubscribe-auth/ABvS22qKncHx021QfRYZMTYR5Rtq7iugks5vdRo5gaJpZM4cWnKH .

iparask commented 5 years ago

@bspitzbart please pull the branch again. @AymenFJA tests found several bugs that I fixed overnight.

bspitzbart commented 5 years ago

Can we have defaults for some of the arguments if users do not specify? reource=xsede.bridges, queue=RM, etc. Then a default model for seals, penguins, rivers, default spectral library for landcover etc.

iparask commented 5 years ago

Can we have defaults for some of the arguments if users do not specify? reource=xsede.bridges, queue=RM, etc. Then a default model for seals, penguins, rivers, default spectral library for landcover etc.

Yes, we can. I'm opening an issue to keep track of it.